refactor(backend): Add back fromDto method and controller method #1644

Author: ManuelMoeri

backend/src/main/java/ch/puzzle/okr/controller/EvaluationViewController.java

@@ -38,21 +38,14 @@ public EvaluationViewController(EvaluationViewMapper evaluationViewMapper,
             @ApiResponse(responseCode = "404", description = "The quarter or one of the teams were not found", content = @Content),
             @ApiResponse(responseCode = "401", description = "Not Authorized", content = @Content) })
     @GetMapping("")
-    public ResponseEntity<EvaluationDto> getEvaluation(
-            @RequestParam(name = "team") List<Long> teamIds,
-            @RequestParam(name = "quarter") Long quarterId) {
-
-        List<EvaluationViewId> ids = teamIds.stream()
-                                            .map(teamId -> EvaluationViewId.Builder.builder()
-                                                                                   .withTeamId(teamId)
-                                                                                   .withQuarterId(quarterId)
-                                                                                   .build())
-                                            .toList();
-
-        EvaluationDto dto = evaluationViewMapper.toDto(
-                evaluationViewBusinessService.findByIds(ids)
-        );
-
-        return ResponseEntity.ok(dto);
+    public ResponseEntity<EvaluationDto> getEvaluation(@RequestParam(name = "team")
+                                                       @Parameter(description = "List of Team ids the statistics are requested for") List<Long> teamIds,
+                                                       @RequestParam(name = "quarter")
+                                                       @Parameter(description = "Quarter id the statistics are requested for ") Long quarterId) {
+        return ResponseEntity
+                .status(HttpStatus.OK)
+                .body(evaluationViewMapper
+                              .toDto(evaluationViewBusinessService
+                                             .findByIds(evaluationViewMapper.fromDto(teamIds, quarterId))));
     }
 }

backend/src/main/java/ch/puzzle/okr/mapper/EvaluationViewMapper.java

@@ -3,6 +3,8 @@
 import ch.puzzle.okr.dto.EvaluationDto;
 import ch.puzzle.okr.models.evaluation.EvaluationView;
 import java.util.List;
+
+import ch.puzzle.okr.models.evaluation.EvaluationViewId;
 import ch.puzzle.okr.service.business.EvaluationViewBusinessService;
 import org.springframework.stereotype.Component;
 
@@ -30,4 +32,8 @@ public EvaluationDto toDto(List<EvaluationView> views) {
                 evaluationService.calculateKeyResultsInStretchSum(views)
         );
     }
-}
+
+    public List<EvaluationViewId> fromDto(List<Long> teamIds, Long quarterId) {
+        return teamIds.stream().map(teamId -> new EvaluationViewId(teamId, quarterId)).toList();
+    }
+}