From 58003aa78d5f5b67fe42bdb8c605b81f5ae0b557 Mon Sep 17 00:00:00 2001 From: Nevio Di Gennaro Date: Fri, 10 Oct 2025 13:04:54 +0200 Subject: [PATCH 1/2] fix: keyresult type check failing because of wrong case #1680 --- .../resources/db/migration/V3_6_3__recreate_evaluation_view.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql b/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql index a2f4091361..3644e36d62 100644 --- a/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql +++ b/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql @@ -15,7 +15,7 @@ SELECT kr.stretch_goal, ci.value_metric, CASE - WHEN kr.key_result_type = 'ORDINAL' THEN NULLIF(ci.zone, '') + WHEN UPPER(kr.key_result_type) = 'ORDINAL' THEN NULLIF(ci.zone, '') ELSE NULL END AS zone, ci.modified_on AS latest_check_in_date From 7de097f9674733dfb6d4be7b57138a50d768e35c Mon Sep 17 00:00:00 2001 From: Nevio Di Gennaro Date: Mon, 27 Oct 2025 13:05:12 +0100 Subject: [PATCH 2/2] fix: recreate correct view in new migration #1680 --- .../V3_6_3__recreate_evaluation_view.sql | 2 +- .../V3_6_5__fix_case_in_evaluation_view.sql | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 backend/src/main/resources/db/migration/V3_6_5__fix_case_in_evaluation_view.sql diff --git a/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql b/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql index 3644e36d62..a2f4091361 100644 --- a/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql +++ b/backend/src/main/resources/db/migration/V3_6_3__recreate_evaluation_view.sql @@ -15,7 +15,7 @@ SELECT kr.stretch_goal, ci.value_metric, CASE - WHEN UPPER(kr.key_result_type) = 'ORDINAL' THEN NULLIF(ci.zone, '') + WHEN kr.key_result_type = 'ORDINAL' THEN NULLIF(ci.zone, '') ELSE NULL END AS zone, ci.modified_on AS latest_check_in_date diff --git a/backend/src/main/resources/db/migration/V3_6_5__fix_case_in_evaluation_view.sql b/backend/src/main/resources/db/migration/V3_6_5__fix_case_in_evaluation_view.sql new file mode 100644 index 0000000000..3644e36d62 --- /dev/null +++ b/backend/src/main/resources/db/migration/V3_6_5__fix_case_in_evaluation_view.sql @@ -0,0 +1,32 @@ +DROP VIEW IF EXISTS EVALUATION_VIEW; + +CREATE VIEW EVALUATION_VIEW AS +SELECT + row_number() OVER () AS row_id, + o.id AS objective_id, + o.team_id, + o.quarter_id, + o.state AS objective_state, + kr.id AS key_result_id, + kr.key_result_type, + kr.baseline, + kr.commit_value, + kr.target_value, + kr.stretch_goal, + ci.value_metric, + CASE + WHEN UPPER(kr.key_result_type) = 'ORDINAL' THEN NULLIF(ci.zone, '') + ELSE NULL + END AS zone, + ci.modified_on AS latest_check_in_date +FROM objective o + LEFT JOIN key_result kr + ON kr.objective_id = o.id + LEFT JOIN LATERAL ( + SELECT ci2.* + FROM check_in ci2 + WHERE ci2.key_result_id = kr.id + ORDER BY ci2.modified_on DESC + LIMIT 1 + ) ci ON TRUE +WHERE o.state <> 'DRAFT'; \ No newline at end of file