test(backend): refactor tests into one parameterized one #541

Author: fstreit1

backend/src/test/java/ch/puzzle/pcts/configuration/AppConfigurationTest.java

@@ -8,7 +8,8 @@
 import jakarta.validation.ValidatorFactory;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 
 class AppConfigurationTest {
 
@@ -21,62 +22,25 @@ void setUp() {
     }
 
     @DisplayName("Should be valid when URL is a correct https link ending in com")
-    @Test
-    void shouldBeValidWhenUrlIsCorrectAndEndingInCom() {
-        var config = new AppConfiguration("https://example.com");
+    @ParameterizedTest
+    @CsvSource("""
+            https://example.com, true,
+            https://example.ch, true,
+            null, false,
+            , false,
+            http://example.com, false,
+            https://.ch, false,
+            https://example.de, false,
+            https://e x am.ch, false
+            """)
+    void shouldReturnExpected(String input, boolean expectedValid) {
+        var config = new AppConfiguration(input);
         var violations = validator.validate(config);
 
-        assertTrue(violations.isEmpty(), "Expected no violations for valid URL");
-    }
-
-    @DisplayName("Should be valid when URL is a correct https link ending in ch")
-    @Test
-    void shouldBeValidWhenUrlIsCorrectAndEndingInCh() {
-        var config = new AppConfiguration("https://example.ch");
-        var violations = validator.validate(config);
-
-        assertTrue(violations.isEmpty(), "Expected no violations for valid URL");
-    }
-
-    @DisplayName("Should have violations when URL is null")
-    @Test
-    void shouldHaveViolationsWhenUrlIsNull() {
-        var config = new AppConfiguration(null);
-
-        var violations = validator.validate(config);
-
-        assertFalse(violations.isEmpty(), "Expected violations for invalid URL");
-    }
-
-    @DisplayName("Should have violations when URL is blank")
-    @Test
-    void shouldHaveViolationsWhenUrlIsBlank() {
-        var config = new AppConfiguration("");
-        var violations = validator.validate(config);
-        assertFalse(violations.isEmpty(), "Expected violations for blank URL");
-    }
-
-    @DisplayName("Should have violations when URL does not start with https://")
-    @Test
-    void shouldHaveViolationsWhenUrlDoesNotStartWithHttps() {
-        var config = new AppConfiguration("http://example.com");
-        var violations = validator.validate(config);
-        assertFalse(violations.isEmpty(), "Expected violations for URL not starting with https://");
-    }
-
-    @DisplayName("Should have violations when URL is shorter than 12 chars")
-    @Test
-    void shouldHaveViolationsWhenUrlIsShorterThan12Chars() {
-        var config = new AppConfiguration("https://.ch");
-        var violations = validator.validate(config);
-        assertFalse(violations.isEmpty(), "Expected violations for URL shorter than 12 chars");
-    }
-
-    @DisplayName("Should have violations when URL does not contain .ch or .com")
-    @Test
-    void shouldHaveViolationsWhenUrlDoesNotContainChOrCom() {
-        var config = new AppConfiguration("https://example.de");
-        var violations = validator.validate(config);
-        assertFalse(violations.isEmpty(), "Expected violations for URL not containing ch or com");
+        if (expectedValid) {
+            assertTrue(violations.isEmpty(), "Expected no violations for: " + input);
+        } else {
+            assertFalse(violations.isEmpty(), "Expected violations for: " + input);
+        }
     }
 }