Skip to content
Lint and test on pull request

Confirm dialog for empty vacation days in new employments (63096) #525

Sign in to view logs

Confirm dialog for empty vacation days in new employments (63096)

Confirm dialog for empty vacation days in new employments (63096) #525

Triggered via pull request December 29, 2025 08:46
@linusfromscratchlinusfromscratch
opened #341
feature/63096-warning-dialog-vacation-days-employments
Status Success
Total duration 5m 39s
Artifacts –

test-on-pr.yaml

on: pull_request
lint  /  lint
1m 9s
lint / lint
test  /  minitest
5m 36s
test / minitest
Fit to window
Zoom out
Zoom in

Annotations

1 notice
[rubocop] app/controllers/employments_controller.rb#L57 <Style/GuardClause>: app/controllers/employments_controller.rb#L57
Use a guard clause (`return unless entry.needs_vacation_days_confirmation? && !params[:confirmed]`) instead of wrapping the code inside a conditional expression.