Skip to content

Commit 53e5024

Browse files
committed
Fix rubocop excludes
1 parent 0b4d4fc commit 53e5024

File tree

2 files changed

+29
-22
lines changed

2 files changed

+29
-22
lines changed

.rubocop.yml

Lines changed: 29 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
---
2+
inherit_mode:
3+
merge:
4+
- Exclude
5+
26
inherit_from: .rubocop_todo.yml
37

48
plugins:
@@ -11,11 +15,21 @@ AllCops:
1115

1216
Metrics:
1317
Exclude:
14-
- 'test/**/*'
18+
- "test/**/*"
19+
20+
Metrics/BlockLength:
21+
Exclude:
22+
- "test/**/*" # Please do not ignore this exclude
23+
- config/routes.rb
24+
25+
Metrics/ModuleLength:
26+
Exclude:
27+
- "test/**/*" # Please do not ignore this exclude
28+
- "app/helpers/evaluator_helper.rb"
1529

1630
Naming/InclusiveLanguage:
1731
Exclude:
18-
- config/environments/development.rb # Bullet uses whitelist :(
32+
- config/environments/development.rb # Bullet uses whitelist :(
1933

2034
# Not gonna rewrite all our tests...
2135
Minitest/MultipleAssertions:
@@ -27,33 +41,28 @@ Rails/ActionControllerTestCase:
2741
# Ignore for existing migrations
2842
Rails/CreateTableWithTimestamps:
2943
Exclude:
30-
- 'db/migrate/20150930143851_create_tables.rb'
31-
- 'db/migrate/20151105101420_create_sectors_and_services.rb'
32-
- 'db/migrate/20160919101807_add_daily_plannings.rb'
33-
- 'db/migrate/20160929150008_create_custom_lists.rb'
34-
- 'db/migrate/20170321095600_employee_master_data.rb'
35-
- 'db/migrate/20170724095653_create_additional_crm_orders.rb'
36-
- 'db/migrate/20190204150125_add_expenses.rb'
37-
- 'db/migrate/20220322152042_create_workplaces.rb'
38-
- 'db/migrate/20230207231358_create_active_storage_variant_records.active_storage.rb'
44+
- "db/migrate/20150930143851_create_tables.rb"
45+
- "db/migrate/20151105101420_create_sectors_and_services.rb"
46+
- "db/migrate/20160919101807_add_daily_plannings.rb"
47+
- "db/migrate/20160929150008_create_custom_lists.rb"
48+
- "db/migrate/20170321095600_employee_master_data.rb"
49+
- "db/migrate/20170724095653_create_additional_crm_orders.rb"
50+
- "db/migrate/20190204150125_add_expenses.rb"
51+
- "db/migrate/20220322152042_create_workplaces.rb"
52+
- "db/migrate/20230207231358_create_active_storage_variant_records.active_storage.rb"
3953

4054
Rails/DangerousColumnNames:
4155
Exclude:
42-
- 'db/migrate/20240311175613_add_id_to_order_team_members.rb' # Added id to many_to_many join table
56+
- "db/migrate/20240311175613_add_id_to_order_team_members.rb" # Added id to many_to_many join table
4357

4458
Style/SafeNavigationChainLength:
4559
Exclude:
46-
- 'app/views/work_items/search.json.jbuilder' # Okish for jbuilder
60+
- "app/views/work_items/search.json.jbuilder" # Okish for jbuilder
4761

4862
Naming/AccessorMethodName:
4963
Exclude:
50-
- 'app/domain/invoicing/small_invoice/client_sync.rb'
64+
- "app/domain/invoicing/small_invoice/client_sync.rb"
5165

5266
Style/SymbolProc:
5367
Exclude:
54-
- 'app/serializers/api/v1/employee_serializer.rb'
55-
56-
Metrics/BlockLength:
57-
Exclude:
58-
- config/routes.rb
59-
...
68+
- "app/serializers/api/v1/employee_serializer.rb"

.rubocop_todo.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ Metrics/MethodLength:
9191
# Configuration parameters: CountComments, CountAsOne.
9292
Metrics/ModuleLength:
9393
Max: 163
94-
Exclude:
95-
- "app/helpers/evaluator_helper.rb"
9694

9795
# Offense count: 2
9896
# Configuration parameters: CountKeywordArgs.

0 commit comments

Comments
 (0)