Fix some rubocop issues

Author: anna-dev

.rubocop_todo.yml

@@ -1,41 +1,20 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-04-24 12:14:19 UTC using RuboCop version 1.72.2.
+# on 2025-12-03 15:37:34 UTC using RuboCop version 1.75.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
----
-# FIXME: Fix these, piece by piece
-
 # Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideArrayLiteralBrackets:
-  Exclude:
-    - 'app/models/employment.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'test/models/employee_test.rb'
-
-# Offense count: 3
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
 Lint/DuplicateBranch:
   Exclude:
-    - 'app/controllers/concerns/worktimes_report.rb'
     - 'app/domain/plannings/employee_board.rb'
 
-# Offense count: 4
+# Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
-    - 'app/domain/forms/multi_absence.rb'
-    - 'app/domain/order/copier.rb'
     - 'app/helpers/dry_crud/form/control.rb'
 
 # Offense count: 1
@@ -45,6 +24,8 @@ Lint/EmptyBlock:
     - 'test/helpers/table_helper_test.rb'
 
 # Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AutoCorrect.
 Lint/LiteralAsCondition:
   Exclude:
     - 'test/helpers/dry_crud/form/builder_test.rb'
@@ -80,44 +61,44 @@ Lint/UnreachableLoop:
   Exclude:
     - 'app/models/working_condition.rb'
 
-# Offense count: 98
+# Offense count: 110
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 282
 
-# Offense count: 51
+# Offense count: 55
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 97
 
-# Offense count: 36
+# Offense count: 38
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
   Max: 314
 
-# Offense count: 17
+# Offense count: 18
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 110
+# Offense count: 129
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 312
 
 # Offense count: 5
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 205
+  Max: 157
 
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 6
   MaxOptionalParameters: 4
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 13
@@ -145,7 +126,7 @@ Naming/HeredocDelimiterNaming:
   Exclude:
     - 'lib/tasks/license.rake'
 
-# Offense count: 14
+# Offense count: 13
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
@@ -160,7 +141,6 @@ Naming/MemoizedInstanceVariableName:
     - 'app/controllers/ordertimes_controller.rb'
     - 'app/controllers/plannings/employees_controller.rb'
     - 'app/controllers/plannings/orders_controller.rb'
-    - 'app/domain/order/cockpit/accounting_post_row.rb'
     - 'app/domain/order/report/entry.rb'
     - 'app/models/util/period.rb'
 
@@ -187,30 +167,23 @@ Naming/MethodParameterName:
 
 # Offense count: 3
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros, UseSorbetSigs.
-# NamePrefix: is_, has_, have_
-# ForbiddenPrefixes: is_, has_, have_
+# NamePrefix: is_, has_, have_, does_
+# ForbiddenPrefixes: is_, has_, have_, does_
 # AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
     - 'app/helpers/dry_crud/form/builder.rb'
     - 'app/models/concerns/belonging_to_work_item.rb'
 
-# Offense count: 5
-# Configuration parameters: EnforcedStyle, AllowedIdentifiers, AllowedPatterns.
-# SupportedStyles: snake_case, camelCase
-Naming/VariableName:
-  Exclude:
-    - 'test/models/worktime_test.rb'
-
 # Offense count: 15
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
+    - 'test/controllers/clients_controller_test.rb'
     - 'test/controllers/contacts_controller_test.rb'
-    - 'test/controllers/employments_controller_test.rb'
     - 'test/controllers/invoices_controller_test.rb'
     - 'test/controllers/orders_controller_test.rb'
     - 'test/controllers/overtime_vacations_controller_test.rb'
@@ -219,12 +192,6 @@ Naming/VariableNumber:
     - 'test/models/invoice_test.rb'
     - 'test/models/order_test.rb'
 
-# Offense count: 1
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'test/controllers/evaluator_controller_test.rb'
-
 # Offense count: 1
 Performance/FixedSize:
   Exclude:
@@ -236,14 +203,6 @@ Performance/MethodObjectAsBlock:
     - 'app/domain/apidocs/setup.rb'
     - 'app/helpers/order_helper.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, AllowToTime.
-# SupportedStyles: strict, flexible
-Rails/Date:
-  Exclude:
-    - 'test/models/employee_test.rb'
-
 # Offense count: 3
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
@@ -269,7 +228,7 @@ Rails/HasManyOrHasOneDependent:
     - 'app/models/service.rb'
     - 'app/models/work_item.rb'
 
-# Offense count: 55
+# Offense count: 61
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
@@ -426,7 +385,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'app/controllers/concerns/worktimes_report.rb'
 
-# Offense count: 315
+# Offense count: 324
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -440,21 +399,11 @@ Style/FrozenStringLiteralComment:
     - 'app/models/application_record.rb'
     - 'test/models/employee_test.rb'
 
-# Offense count: 2
-# Configuration parameters: MinBranchesCount.
-Style/HashLikeCase:
-  Exclude:
-    - 'app/domain/order/report.rb'
-    - 'app/helpers/order_helper.rb'
-
-# Offense count: 4
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Exclude:
-    - 'app/controllers/order_targets_controller.rb'
-    - 'app/domain/forms/worktime_edit.rb'
     - 'app/domain/plannings/employee_board.rb'
-    - 'app/models/accounting_post.rb'
 
 # Offense count: 2
 Style/MissingRespondToMissing:
@@ -473,25 +422,15 @@ Style/OpenStructUse:
     - 'app/controllers/order_services_controller.rb'
     - 'test/controllers/employees_controller_test.rb'
 
-# Offense count: 25
+# Offense count: 27
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: respond_to_missing?
 Style/OptionalBooleanParameter:
   Enabled: false
 
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Exclude:
-    - 'app/controllers/evaluator_controller.rb'
-    - 'app/domain/order/services/csv_filename_generator.rb'
-    - 'lib/tasks/license.rake'
-
-# Offense count: 38
+# Offense count: 66
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Max: 234
-...

app/controllers/concerns/worktimes_report.rb

@@ -86,16 +86,10 @@ def combine_ticket_employees(combined_tickets, employees, worktime)
   end
 
   def combine_ticket_date_range(date_range, worktime)
-    if date_range[0].nil?
-      date_range[0] = worktime.work_date
-    elsif worktime.work_date < date_range[0]
-      date_range[0] = worktime.work_date
-    end
+    date_range[0] = worktime.work_date if date_range[0].nil? || (worktime.work_date < date_range[0])
 
-    if date_range[1].nil?
-      date_range[1] = worktime.work_date
-    elsif worktime.work_date > date_range[1]
-      date_range[1] = worktime.work_date
-    end
+    return unless date_range[1].nil? || (worktime.work_date > date_range[1])
+
+    date_range[1] = worktime.work_date
   end
 end

app/controllers/evaluator_controller.rb

@@ -63,7 +63,7 @@ def report
       @period.to_s.parameterize
     ].compact
 
-    filename = file_parts.compact.join('-') + '.pdf'
+    filename = "#{file_parts.compact.join('-')}.pdf"
 
     send_data pdf_generator.generate_pdf.render,
               filename: filename,
@@ -73,8 +73,8 @@ def report
 
   def export_csv
     set_evaluation_details
-    filename = ['puzzletime', csv_label(@evaluation.category),
-                csv_label(@evaluation.division)].compact.join('-') + '.csv'
+    filename = "#{['puzzletime', csv_label(@evaluation.category),
+                   csv_label(@evaluation.division)].compact.join('-')}.csv"
     times = @evaluation.times(@period)
     send_worktimes_csv(times, filename)
   end

app/controllers/order_targets_controller.rb

@@ -23,9 +23,7 @@ def update
   def update_targets
     @errors = OrderTarget.new.errors
     @order_targets.each do |target|
-      unless target.update(target_params(target))
-        target.errors.each { |error| @errors.add(error.attribute, error.message) }
-      end
+      target.errors.each { |error| @errors.add(error.attribute, error.message) } unless target.update(target_params(target))
     end
   end
 

app/domain/forms/multi_absence.rb

@@ -8,7 +8,7 @@
 module Forms
   class MultiAbsence
     attr_accessor :employee
-    attr_reader :absence_id, :work_date, :duration, :description, :worktime
+    attr_reader :absence_id, :description, :worktime
 
     def initialize
       @duration = 1

app/domain/forms/worktime_edit.rb

@@ -10,9 +10,7 @@ class WorktimeEdit < Forms::Splitable
     self.incomplete_finish = false
 
     def add_worktime(worktime)
-      if worktime.hours - remaining_hours > 0.00001 # we are working with floats: use delta
-        worktime.errors.add(:hours, 'Die gesamte Anzahl Stunden kann nicht vergrössert werden')
-      end
+      worktime.errors.add(:hours, 'Die gesamte Anzahl Stunden kann nicht vergrössert werden') if worktime.hours - remaining_hours > 0.00001 # we are working with floats: use delta
       worktime.employee = original.employee
       super if worktime.errors.empty?
       worktime.errors.empty?

app/domain/order/copier.rb

@@ -7,14 +7,16 @@
 
 class Order
   class Copier
-    attr_reader :source, :copy
+    attr_reader :source
 
     def initialize(source)
       @source = source
     end
 
     # Copies an order together with everything that is edited in the order form.
     def copy
+      return @copy if defined?(@copy)
+
       @copy = source.dup
       @copy.work_item = source.work_item.dup
       @copy.work_item.parent_id = source.work_item.parent_id

app/domain/order/report.rb

@@ -176,21 +176,18 @@ def filter_by_closed(orders)
 
     def filter_by_uncertainty(orders, attr)
       if params[attr].present?
-        orders.where(attr => map_uncertainties_filter(params[attr]))
+        orders.where(attr => uncertainties_filter[params[attr]])
       else
         orders
       end
     end
 
-    def map_uncertainties_filter(value)
-      case value
-      when 'low'
-        0..2
-      when 'medium'
-        3..7
-      when 'high'
-        8..16
-      end
+    def uncertainties_filter
+      @uncertainties_filter ||= {
+        'low' => 0..2,
+        'medium' => 3..7,
+        'high' => 8..16
+      }
     end
 
     def sort_entries(entries)

app/domain/order/services/csv_filename_generator.rb

@@ -16,18 +16,21 @@ def initialize(order, params = {})
       end
 
       def filename
+        "#{filename_prefix}.csv"
+      end
+
+      private
+
+      def filename_prefix
         ['puzzletime',
          accounting_post_shortnames || order_shortnames,
          employee_shortname,
          ticket,
          billable]
           .compact
-          .join('-') +
-          '.csv'
+          .join('-')
       end
 
-      private
-
       def order_shortnames
         order.work_item.path_shortnames
       end