add filter to ahow / hide orders without any worktimes

Author: svenwey

app/controllers/order_reports_controller.rb

@@ -15,7 +15,6 @@ class OrderReportsController < ApplicationController
                             major_risk_value]
 
   before_action :authorize_class
-  before_action :show_without_hours
 
   def index
     set_period
@@ -36,10 +35,6 @@ def index
 
   private
 
-  def show_without_hours
-    params[:without_hours] = true if params[:status_preselection].presence
-  end
-
   def set_filter_values
     @departments = Department.list
     @clients = WorkItem.joins(:client).list

app/domain/order/report.rb

@@ -133,7 +133,7 @@ def build_entry(order, accounting_posts, hours, invoices)
     end
 
     def show_without_hours?
-      params[:without_hours].presence || false
+      params[:without_hours] == 'true'
     end
 
     def booked_hours?(post_hours)

app/views/order_reports/_filters.html.haml

@@ -59,6 +59,12 @@
                          class: 'searchable',
                          multiple: true)
 
+  = direct_filter_select(:without_hours,
+                         'Aufträge ohne Zeitbuchungen',
+                         [IdValue.new('true', 'anzeigen'), IdValue.new('false', 'verbergen')],
+                         class: 'searchable',
+                         value: params[:without_hours] ||= true)
+
   = direct_filter(:target, 'Ziel') do
     - select_tag(:target,
                  options_for_select([['Orange', 'orange'],