Fix ErrorTracker method namings

Author: anna-dev

.reek.yml

@@ -1,5 +1,4 @@
 ### Generic smell configuration
-
 ---
 # detectors:
 ## You can disable smells completely
@@ -49,7 +48,6 @@
 #   - lib/rake/legacy_tasks
 #   - lib/smelly.rb
 
-
 # FIXME: Fix these, piece by piece
 
 # Auto generated by Reeks --todo flag
@@ -1955,21 +1953,17 @@ detectors:
       - WorkloadReportController#default_period
       - Apidocs::Setup#setup_property
       - Apidocs::Setup#setup_tags
-      - Crm::Highrise#airbrake?
       - Crm::Highrise#base_url
       - Crm::Highrise#contact_attributes
       - Crm::Highrise#existing_contact_crm_keys
       - Crm::Highrise#find_people_by_email
       - Crm::Highrise#record_to_params
-      - Crm::Highrise#sentry?
       - Crm::Highrise#sync_additional_order
-      - Crm::Odoo#airbrake?
       - Crm::Odoo#base_url
       - Crm::Odoo#contact_attributes
       - Crm::Odoo#existing_contact_crm_keys
       - Crm::Odoo#find_people_by_email
       - Crm::Odoo#record_to_params
-      - Crm::Odoo#sentry?
       - Crm::Odoo#sync_additional_order
       - Evaluations::AbsencesEval#divisions
       - Evaluations::ClientsEval#divisions
@@ -2094,8 +2088,6 @@ detectors:
       - WorktimeHelper#week_number
       - WorktimeHelper#worktime_account
       - WorktimeHelper#worktime_description
-      - ApplicationJob#airbrake?
-      - ApplicationJob#sentry?
       - CommitReminderJob#perform
       - CrmSyncJob#perform
       - InvoicingSyncJob#perform

app/controllers/application_controller.rb

@@ -85,7 +85,7 @@ def set_error_tracker_user_context
     ErrorTracker.set_user(
       id: current_user.try(:id),
       username: current_user.try(:shortname),
-      email: current_user.email
+      email: current_user.try(:email)
     )
   end
 

app/domain/error_tracker.rb

@@ -18,22 +18,22 @@ def report_exception(error, payload)
 
     def set_tags(**kwargs)
       Sentry.set_tags(**kwargs) if sentry_like?
-      Airbrake.merge_context(tags: kwargs) if airbrake?
+      Airbrake.merge_context(tags: kwargs) if airbrake_like?
     end
 
     def set_extras(**kwargs)
       Sentry.set_extras(**kwargs) if sentry_like?
-      Airbrake.merge_context(extra: kwargs) if airbrake?
+      Airbrake.merge_context(extra: kwargs) if airbrake_like?
     end
 
     def set_user(**kwargs)
       Sentry.set_user(**kwargs) if sentry_like?
-      Airbrake.merge_context(user: kwargs) if airbrake?
+      Airbrake.merge_context(user: kwargs) if airbrake_like?
     end
 
     def set_contexts(**)
       Sentry.set_contexts(**) if sentry_like?
-      Airbrake.merge_context(**) if airbrake?
+      Airbrake.merge_context(**) if airbrake_like?
     end
 
     def airbrake_like?