Fix and enhance tests aswell as json fixtures

Author: ManuelMoeri

spec/fixtures/files/json/wally.json

@@ -6,18 +6,22 @@
       "shortname": "CAL",
       "firstname": "Changed Wally",
       "lastname": "Allround",
-      "full_name": "Changed Wally Allround",
       "email": "[email protected]",
       "marital_status": "single",
       "nationalities": [
         "DE", "DK"
       ],
       "graduation": "Quarter-Stack Developer",
       "department_shortname": "SYS",
-      "employment_roles2": [],
+      "employment_roles": [
+        {
+          "name": "Newest employment role",
+          "percent": 100.0
+        }
+      ],
       "is_employed": false,
-      "birthdate": "1.1.2000",
-      "location": "Basel"
+      "birthday": "1.1.2000",
+      "city": "Basel"
     }
   }
 }

spec/requests/people_employees_spec.rb

@@ -25,18 +25,15 @@
     expect(person_wally.email).to eq('[email protected]')
 
     get "/de/people/#{person_wally.id}"
-    expect(response).to render_template(:show)
 
     person_wally.reload
     expect(person_wally.name).to eq('Changed Wally Allround')
     expect(person_wally.shortname).to eq('CAL')
     expect(person_wally.email).to eq('[email protected]')
     expect(person_wally.marital_status).to eq('single')
     expect(person_wally.title).to eq('Quarter-Stack Developer')
-    # Can be commented in when the updated PTime API has been released and the mapping in the 'people_employees.rb' has been fixed
-
-    # expect(person_wally.birthdate.to_date).to eq(Date.parse('1.1.2000'))
-    # expect(person_wally.location).to eq('Basel')
+    expect(person_wally.birthdate.to_date).to eq(Date.parse('1.1.2000'))
+    expect(person_wally.location).to eq('Basel')
     expect(person_wally.nationality).to eq('DE')
     expect(person_wally.nationality2).to eq('DK')
   end
@@ -57,10 +54,8 @@
     expect(new_wally.email).to eq('[email protected]')
     expect(new_wally.marital_status).to eq('single')
     expect(new_wally.title).to eq('Quarter-Stack Developer')
-    # Can be commented in when the updated PTime API has been released and the mapping in the 'people_employees.rb' has been fixed
-
-    # expect(new_wally.birthdate).to eq('1.1.2000')
-    # expect(new_wally.location).to eq('Basel')
+    expect(new_wally.birthdate).to eq('1.1.2000')
+    expect(new_wally.location).to eq('Basel')
     expect(new_wally.nationality).to eq('DE')
     expect(new_wally.nationality2).to eq('DK')
   end