Implement specs that test setting of locale cookie and if it is correctly set and read

Author: RandomTannenbaum

Diff for: spec/controllers/people_controller_spec.rb

@@ -23,4 +23,20 @@
       expect(people(:bob).reload.nationality2).to eql("DE")
     end
   end
+
+  describe 'handling of locale' do
+    it 'it should correctly set locale cookie' do
+      # Check if locale cookie is not set by default
+      get :index, params: {locale: :fr}
+      expect(response.cookies['locale']).to be_nil
+
+      # Check if locale cookie is set if it is changed by user
+      get :index, params: {locale: :fr, set_by_user: true}
+      expect(response.cookies['locale']).to eql('fr')
+
+      # Cookie should not be changed if user requests page with other locale
+      get :index, params: {locale: :en}
+      expect(response.cookies['locale']).to be_nil
+    end
+  end
 end

Diff for: spec/features/routing_spec.rb

@@ -29,11 +29,20 @@
     context "Set locale via dropdown" do
       before(:each) do
         visit people_path
-        select 'Italiano', from: "i18n_language"
       end
 
       it "Should open profile with correct language and preserve language in cookie" do
-        # Simulate revisit without a locale in the url
+        select 'Italiano', from: "i18n_language"
+
+        select_from_slim_select("#person_id_person", bob.name)
+        expect(page).to have_text("Dati personali")
+
+        # Visiting page with locale explicitly defined in route should use locale from route
+        visit '/en/'
+        select_from_slim_select("#person_id_person", bob.name)
+        expect(page).to have_text("Personal details")
+
+        # Simulate revisit without a locale in the url, which should use locale from cookie
         visit '/'
 
         select_from_slim_select("#person_id_person", bob.name)