Description
Is your feature request related to a problem? Please describe.
pvlib.pvsystem.sapm
requires effective irradiance and SAPM coefficients as inputs.
pvlib-python/pvlib/pvsystem.py
Lines 2169 to 2171 in 22364d8
pvlib-python/pvlib/pvsystem.py
Lines 2176 to 2178 in 22364d8
effective_irradiance
considers AOI/spectrum. The notes section explaining module
contains a table explaining the SAPM coefficients:
pvlib-python/pvlib/pvsystem.py
Lines 2194 to 2235 in 22364d8
I'm wondering whether any clarification over which coefficients are actually used is necessary. I think it's helpful to present the full table, but could someone be misled into thinking that since A0-A4
are required, a spectral correction is being applied (for example)
Describe the solution you'd like
Suggestion: add a line or two to the notes section clarifying which coefficients are used.
Describe alternatives you've considered
Such a revision could be redundant since effective_irradiance
is already clearly (and correctly) defined. However, when I first glanced over these docs, I just felt like some clarification could help some users. Not a major issue; I am interested to hear whether anyone else thinks this would help or not.
Activity