Skip to content

Commit abea3ae

Browse files
committed
Adds color to warning messages in Android packaging. Fixes typo in Android platform.
1 parent 6527e8a commit abea3ae

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

apps/pwabuilder-google-play/services/packageCreator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export class PackageCreator {
143143
errorMessage.includes('ENOTFOUND');
144144
if (is403Error) {
145145
const optionsWithSafeUrl = this.getAndroidOptionsWithSafeUrls(options);
146-
this.dispatchProgressEvent('Encountered 403 error when generating app package. This indicates PWABuilder was unable to downlaod the images in your web manifest. If the problem persists, please ensure the images specified in your manfiest can be fetched without 404s, redirects, or authentication walls. Retrying with safe URL proxy and HTTP2.', "warn");
146+
this.dispatchProgressEvent('Encountered 403 error when generating app package. This indicates PWABuilder was unable to download the images in your web manifest. If the problem persists, please ensure the images specified in your manfiest can be fetched without 404s, redirects, or authentication walls. Retrying with safe URL proxy and HTTP2.', "warn");
147147
const bubbleWrapper = new BubbleWrapper(
148148
optionsWithSafeUrl,
149149
projectDirPath,

apps/pwabuilder/Frontend/src/script/pages/google-play-packaging-status.styles.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ export const googlePlayPackagingStatusStyles = css`
103103
background-color: var(--sl-color-neutral-300);
104104
}
105105
106+
&.warn {
107+
color: var(--sl-color-warning-600);
108+
}
109+
106110
&.error {
107111
color: var(--sl-color-danger-600);
108112
}

apps/pwabuilder/Frontend/src/script/pages/google-play-packaging-status.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,15 @@ export class GooglePlayPackagingStatus extends LitElement {
167167
}
168168

169169
renderLog(log: string): TemplateResult {
170+
let logClass = "log";
170171
if (log.includes("[error]")) {
171-
return html`<span class="log error">${log}</span>`;
172+
logClass += " error";
172173
}
173-
return html`<span class="log">${log}</span>`;
174+
if (log.includes("[warn]")) {
175+
logClass += " warn";
176+
}
177+
178+
return html`<span class="${logClass}">${log}</span>`;
174179
}
175180

176181
private async pollJob(jobId: string): Promise<void> {

0 commit comments

Comments
 (0)