Aligns Chrome for Testing version with compatible version of PuppeteerSharp

Author: JudahGabriel

Dockerfile.production

@@ -2,17 +2,19 @@
 FROM mcr.microsoft.com/dotnet/aspnet:9.0 AS base
 
 # Install dependencies for Puppeteer (runtime only, no Node.js needed here)
+# Install Chrome version 138.0.7204.101 to match PuppeteerSharp 20.2.x default. 
+# IMPORTANT: Changing the PuppeteerSharp version or the Chrome version independently may break things. Only use compatible versions.
 RUN apt-get update && apt-get install -y \
     wget \
     gnupg \
     ca-certificates \
     procps \
     libxss1 \
-    && wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | apt-key add - \
-    && sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \
-    && apt-get update \
-    && apt-get install -y google-chrome-stable fonts-ipafont-gothic fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst fonts-freefont-ttf libxss1 \
+    fonts-ipafont-gothic fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst fonts-freefont-ttf \
     --no-install-recommends \
+    && wget -q https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_138.0.6957.99-1_amd64.deb \
+    && apt-get install -y ./google-chrome-stable_138.0.6957.99-1_amd64.deb \
+    && rm google-chrome-stable_138.0.6957.99-1_amd64.deb \
     && rm -rf /var/lib/apt/lists/*
 
 WORKDIR /app

apps/pwabuilder/Services/ServiceWorkerAnalyzer.cs

@@ -106,10 +106,9 @@ public async Task<PwaCapability> TryRunOfflineCheck(ServiceWorkerDetection? swDe
             // To test offline capability, we load the page in puppeteer. Then we disconnect the network and try to reload the page.
             // If the page loads successfully while offline, we mark the capability as passed.
             // NOTE: in the past we used Lighthouse's offline audit for this check. But as of summer 2025, Lighthouse has removed PWA audits including offline support audit.
-            IPage? page = null;
             try
             {
-                page = await puppeteerService.NavigateAsync(appUrl);
+                using var page = await puppeteerService.NavigateAsync(appUrl);
                 cancelToken.ThrowIfCancellationRequested();
 
                 // Wait for network to be idle
@@ -138,7 +137,7 @@ public async Task<PwaCapability> TryRunOfflineCheck(ServiceWorkerDetection? swDe
                 cancelToken.ThrowIfCancellationRequested();
 
                 // Disconnect network
-                page = await SetOfflineModeWithDisconnectedFallback(page, appUrl, logger);
+                await page.SetOfflineModeAsync(true);
 
                 // Try to reload the page
                 var response = await page.ReloadAsync(new NavigationOptions
@@ -166,46 +165,10 @@ public async Task<PwaCapability> TryRunOfflineCheck(ServiceWorkerDetection? swDe
                 logger.LogWarning(ex, "Error checking offline capability for {url}", appUrl);
                 offlineCapability.Status = PwaCapabilityCheckStatus.Failed;
             }
-            finally
-            {
-                if (page != null)
-                {
-                    page.Dispose();
-                }
-            }
 
             return offlineCapability;
         }
 
-        private async Task<IPage> SetOfflineModeWithDisconnectedFallback(IPage page, Uri appUrl, ILogger logger)
-        {
-            try
-            {
-                // Try to set offline mode. 
-                await page.SetOfflineModeAsync(true);
-                return page;
-            }
-            catch (TargetClosedException closedError)
-            {
-                // Some PWAs, such as https://belgrade.plus, have a disconnection error after waiting for service worker. 
-                // Re-navigate the page and immediately set offline mode since we've already loaded it.
-                logger.LogWarning(closedError, "During offline detection test, the page disconnected. Reloading the page.");
-                using var newPage = await this.puppeteerService.NavigateAsync(appUrl);
-                await newPage.SetOfflineModeAsync(true);
-
-                try
-                {
-                    page.Dispose();
-                }
-                catch (Exception disposeError)
-                {
-                    logger.LogWarning(disposeError, "Error disposing Puppeteer page during offline detection fallback.");
-                }
-
-                return newPage;
-            }
-        }
-
         private PwaCapabilityCheckStatus RunCapabilityCheck(PwaCapability swCapability, ServiceWorkerDetection swDetection, string swScripts)
         {
             return swCapability.Id switch