Skip to content

Commit 89f1e73

Browse files
committed
Minor protocol fixes
1 parent 3118db2 commit 89f1e73

7 files changed

Lines changed: 17 additions & 12 deletions

File tree

grizabella/mcp/server.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ async def mcp_create_embedding_definition(embedding_def: EmbeddingDefinition) ->
393393
async def mcp_begin_bulk_addition():
394394
try:
395395
get_grizabella_client().begin_bulk_addition()
396-
return "Bulk addition mode started."
396+
return # Return None for successful bulk addition start
397397
except Exception as e:
398398
logger.error(f"MCP: Error starting bulk addition: {e}")
399399
raise
@@ -406,7 +406,7 @@ async def mcp_begin_bulk_addition():
406406
async def mcp_finish_bulk_addition():
407407
try:
408408
get_grizabella_client().finish_bulk_addition()
409-
return "Bulk addition mode finished and embeddings generated."
409+
return # Return None for successful bulk addition completion
410410
except Exception as e:
411411
logger.error(f"MCP: Error finishing bulk addition: {e}")
412412
raise
@@ -966,7 +966,12 @@ def shutdown_handler(signum, frame):
966966
print(f"Received signal {signum}, shutting down...", file=sys.stderr)
967967
except Exception:
968968
# sys.stderr might not be available during shutdown
969-
print(f"Received signal {signum}, shutting down...")
969+
# Using stderr even for the fallback to avoid stdout contamination
970+
try:
971+
print(f"Received signal {signum}, shutting down...", file=sys.stderr)
972+
except Exception:
973+
# If even stderr fails, just use logger
974+
pass
970975

971976
logger.info(f"Received signal {signum}, shutting down...")
972977

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "grizabella"
3-
version = "0.6.0"
3+
version = "0.6.1"
44
description = "A tri-layer memory framework for LLM solutions."
55
authors = ["Grizabella Project Contributors <contributors@example.com>"]
66
readme = "README.md"

typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "grizabella-typescript-api",
3-
"version": "0.2.0",
3+
"version": "0.2.1",
44
"type": "module",
55
"description": "TypeScript API client for Grizabella multi-database knowledge graph operations through MCP communication",
66
"main": "dist/index.js",

typescript/src/client/GrizabellaClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export class GrizabellaClient {
142142
* ```
143143
*/
144144
constructor(config: GrizabellaClientConfig) {
145-
process.stdout.write('=== GrizabellaClient constructor called with config: ' + JSON.stringify(config, null, 2) + '\n');
145+
process.stderr.write('=== GrizabellaClient constructor called with config: ' + JSON.stringify(config, null, 2) + '\n');
146146

147147
// Store and resolve database configuration
148148
this._dbNameOrPath = GrizabellaClient.resolveDatabasePath(config.dbNameOrPath ?? 'default');

typescript/src/client/MCPClient.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@ export class MCPClient {
153153
this.maxReconnectAttempts = this.config.maxReconnectAttempts;
154154
this.reconnectDelay = this.config.reconnectDelay;
155155

156-
process.stdout.write('MCPClient final config debug=' + this.config.debug + '\n');
156+
process.stderr.write('MCPClient final config debug=' + this.config.debug + '\n');
157157
if (this.config.debug) {
158-
process.stdout.write('MCPClient created with debug enabled, config:' + JSON.stringify(this.config, null, 2) + '\n');
158+
process.stderr.write('MCPClient created with debug enabled, config:' + JSON.stringify(this.config, null, 2) + '\n');
159159
}
160160
}
161161

@@ -923,7 +923,7 @@ export class MCPClient {
923923
*/
924924
async executeComplexQuery(params: ExecuteComplexQueryParams): Promise<QueryResult> {
925925
if (this.config.debug) {
926-
process.stdout.write('MCPClient.executeComplexQuery called with:' + JSON.stringify(params, null, 2) + '\n');
926+
process.stderr.write('MCPClient.executeComplexQuery called with:' + JSON.stringify(params, null, 2) + '\n');
927927
}
928928

929929
const rawResult = await this.callTool<unknown>('execute_complex_query', {

typescript/src/client/errors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ export interface ErrorLogger {
817817
*/
818818
export class ConsoleErrorLogger implements ErrorLogger {
819819
log(error: GrizabellaError): void {
820-
console.log(error.getDetailedMessage(), error.toJSON());
820+
console.error(error.getDetailedMessage(), error.toJSON());
821821
}
822822

823823
warn(error: GrizabellaError): void {

typescript/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,11 @@ export { GrizabellaClient, GrizabellaClientConfig, ClientConnectionState } from
176176
// Main initialization function (to be implemented)
177177
export function initialize(): void {
178178
// TODO: Initialize the Grizabella client
179-
console.log('Grizabella TypeScript API initialized');
179+
console.error('Grizabella TypeScript API initialized');
180180
}
181181

182182
// Main cleanup function (to be implemented)
183183
export function cleanup(): void {
184184
// TODO: Clean up resources
185-
console.log('Grizabella TypeScript API cleanup');
185+
console.error('Grizabella TypeScript API cleanup');
186186
}

0 commit comments

Comments
 (0)