Skip to content

Few minor issues #160

Open
Open
@vertexodessa

Description

@vertexodessa

Revision 1bc7069 (to make sure all the lines are correct)

Incorrect variable assignment:

  ret = inet_pton(ss.ss_family, host, addr);
  if (ret != 1)
  {
    int err = errno;
    rtLogError("failed to parse: %s as valid ipv4 address", host);
    error = rtErrorFromErrno(err);
  }
  error = RT_OK;

"error" is used incorrectly. it will always be equal to RT_OK.
rtRemoteSocketUtils.cpp: 196, 198


Incorrect/strict float comparison:
pxScene2d.cpp: lines 506, 513, 532, 543, 932, 975, 984
pxContextGL.cpp: lines 1072, 1074, 1625, 1642
pxFont.cpp: 310
pxText.cpp: 123, 157
pxTextBox.cpp: 272, 463, 479, 743, 770, 840, 856, 872, 875, 896, 902, 1027
pxImage.cpp: 136, 146
pxImage9.cpp: 88, 89
pxInterpolators.cpp: 18, 21, 64, 169
rtValue.cpp: 53, 54, 280, 281


pxMatrix4T class implements copy ctor but not "operator ="

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions