Skip to content

Commit 2436f4e

Browse files
committed
Disable failing tests against fixest due to #1167
1 parent 262f7d4 commit 2436f4e

File tree

2 files changed

+29
-9
lines changed

2 files changed

+29
-9
lines changed

pyfixest/estimation/formula/model_matrix.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,11 @@ def _process(self, dropped_rows: set[int], drop_singletons: bool = False) -> Non
122122
warnings.warn(
123123
f"{is_infinite.sum()} rows with infinite values dropped from the model.",
124124
)
125-
if self.fixed_effects is not None:
125+
if self._fixed_effects is not None:
126126
# Ensure fixed effects are `int32`
127-
self._data[self._fixed_effects] = self.fixed_effects.astype("int32")
127+
self._data[self._fixed_effects] = self._data[self._fixed_effects].astype(
128+
"int32"
129+
)
128130
if self.fixed_effects is not None or self._drop_intercept:
129131
if self._independent is not None:
130132
self._independent = [

tests/test_vs_fixest.py

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -962,26 +962,44 @@ def test_glm_vs_fixest(N, seed, dropna, fml, inference, family):
962962
("Y + Y2 ~ X1 | csw0(f1,f2)"),
963963
("Y + log(Y2) ~ sw(X1, X2) | csw0(f1,f2,f3)"),
964964
("Y ~ C(f2):X2 + sw0(X1, f3)"),
965-
# Multiple estimation with variable combinations (e.g., f1+f2 as a single step)
966-
("Y ~ X1 | sw0(f1, f1+f2)"),
967-
("Y ~ X1 | csw0(f1, f1+f2)"),
968-
("Y ~ X1 | sw(f1, f1+f2)"),
965+
# TODO: enable once fixest bug is fixed, see https://github.com/lrberge/fixest/issues/631
966+
pytest.param(
967+
"Y ~ X1 | sw0(f1, f1+f2)",
968+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
969+
),
970+
pytest.param(
971+
"Y ~ X1 | csw0(f1, f1+f2)",
972+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
973+
),
974+
pytest.param(
975+
"Y ~ X1 | sw(f1, f1+f2)",
976+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
977+
),
978+
pytest.param(
979+
"Y ~ X1 | sw0(f1, f1+f2, f1+f2+f3)",
980+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
981+
),
982+
pytest.param(
983+
"Y ~ X1 | csw0(f1, f1+f2, f1+f2+f3)",
984+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
985+
),
986+
pytest.param(
987+
"Y ~ X1 | mvsw(f1, f2)",
988+
marks=pytest.mark.skip(reason="fixest nparams bug (#631)"),
989+
),
969990
("Y ~ X1 | csw(f1, f1+f2)"),
970991
("Y ~ sw0(X1, X1+X2)"),
971992
("Y ~ csw0(X1, X1+X2)"),
972993
("Y ~ sw(X1, X1+X2)"),
973994
("Y ~ X1 + sw0(X2, X2+f1)"),
974995
("Y ~ X1 + csw0(X2, X2+f1)"),
975-
("Y ~ X1 | sw0(f1, f1+f2, f1+f2+f3)"),
976-
("Y ~ X1 | csw0(f1, f1+f2, f1+f2+f3)"),
977996
("Y + Y2 ~ X1 | sw0(f1, f1+f2)"),
978997
("Y + Y2 ~ sw0(X1, X1+X2) | f1"),
979998
# mvsw() cases - multiverse stepwise (all combinations)
980999
("Y ~ mvsw(X1, X2)"),
9811000
("Y ~ mvsw(X1, X2) | f1"),
9821001
("Y ~ X1 + mvsw(X2, f1)"),
9831002
("Y ~ X1 + mvsw(X2, f1) | f2"),
984-
("Y ~ X1 | mvsw(f1, f2)"),
9851003
("Y + Y2 ~ mvsw(X1, X2)"),
9861004
("Y + Y2 ~ mvsw(X1, X2) | f1"),
9871005
("Y ~ mvsw(X1, X2, f1)"),

0 commit comments

Comments
 (0)