Introducing pre_code_font optional parameter for FPDF.write_html() (#777)

Author: Lucas-C

CHANGELOG.md

@@ -21,6 +21,7 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
 - documentation on how to embed `graphs` and `charts` generated using `Pygal` lib: [documentation section](https://pyfpdf.github.io/fpdf2/Maths.html#using-pygal) - thanks to @ssavi-ict
 - documentation on how to use `fpdf2` with [FastAPI](https://fastapi.tiangolo.com/): <https://pyfpdf.github.io/fpdf2/UsageInWebAPI.html#FastAPI> - thanks to @KamarulAdha
 - [`FPDF.write_html()`](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.write_html): `<table>` elements can now be aligned left or right on the page using `align=`
+- [`FPDF.write_html()`](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.write_html): a custom font can now be specified for `<code>` & `<pre>` elements, using the new optional parameter `pre_code_font`
 ### Fixed
 - [`FPDF.table()`](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.table): images no more overflow cells
 - [`FPDF.table()`](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.table): text overflow in the last cell of the header row is now properly handled

fpdf/html.py

@@ -206,6 +206,7 @@ def __init__(
         table_line_separators=False,
         ul_bullet_char=BULLET_WIN1252,
         heading_sizes=None,
+        pre_code_font="courier",
         warn_on_tags_not_matching=True,
         **_,
     ):
@@ -244,6 +245,7 @@ def __init__(
         self.heading_below = 0.2  # extra space below heading, relative to font size
         if heading_sizes:
             self.heading_sizes.update(heading_sizes)
+        self.pre_code_font = pre_code_font
         self.warn_on_tags_not_matching = warn_on_tags_not_matching
         self._tags_stack = []
         # <table>-related properties:
@@ -375,10 +377,10 @@ def handle_starttag(self, tag, attrs):
             self.pdf.add_page(same=True)
         if tag == "code":
             self.font_stack.append((self.font_face, self.font_size, self.font_color))
-            self.set_font("courier", 11)
+            self.set_font(self.pre_code_font, 11)
         if tag == "pre":
             self.font_stack.append((self.font_face, self.font_size, self.font_color))
-            self.set_font("courier", 11)
+            self.set_font(self.pre_code_font, 11)
             self.pre_formatted = True
         if tag == "blockquote":
             self.pdf.set_text_color(100, 0, 45)

test/fonts/DejaVuSansMono.ttf

@@ -232,7 +232,7 @@ def test_html_justify_paragraph(tmp_path):
 
 def test_issue_156(tmp_path):
     pdf = FPDF()
-    pdf.add_font("Roboto", style="B", fname="test/fonts/Roboto-Bold.ttf")
+    pdf.add_font("Roboto", style="B", fname=HERE / "../fonts/Roboto-Bold.ttf")
     pdf.set_font("Roboto", style="B")
     pdf.add_page()
     with pytest.raises(FPDFException) as error:
@@ -440,3 +440,11 @@ def test_html_unorthodox_headings_hierarchy(tmp_path):  # issue 631
            <h5>H5</h5>"""
     )
     assert_pdf_equal(pdf, HERE / "html_unorthodox_headings_hierarchy.pdf", tmp_path)
+
+
+def test_html_custom_pre_code_font(tmp_path):  # issue 770
+    pdf = FPDF()
+    pdf.add_font(fname=HERE / "../fonts/DejaVuSansMono.ttf")
+    pdf.add_page()
+    pdf.write_html("<code> Cześć! </code>", pre_code_font="DejaVuSansMono")
+    assert_pdf_equal(pdf, HERE / "html_custom_pre_code_font.pdf", tmp_path)