Changelog and tests (#1109)

Author: andersonhc

CHANGELOG.md

@@ -33,6 +33,7 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
 * fixed gutter handing when a pagebreak occurs within a table with header rows - thanks to @mjasperse
 * fixed handling of `border=0` in HTML table - thanks to @mjasperse
 * [`FPDF.write_html()`](https://py-pdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.write_html) now properly honors `align=` attributes in `<th>` tags
+* fixed problem using bold italic standard fonts in markdown - thanks to @Alan-Collins
 ### Changed
 * refactored [`FPDF.multi_cell()`](https://py-pdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.multi_cell) to generate fewer PDF component objects - thanks to @mjasperse
 * outer table borders are now drawn continuously for nonzero `gutter_width`/`gutter_height`, with spacing applied inside the border similar to HTML tables - thanks to @mjasperse - cf. [#1071](https://github.com/py-pdf/fpdf2/issues/1071)

fpdf/fpdf.py

@@ -3214,23 +3214,20 @@ def _preload_font_styles(self, text, markdown):
             prev_font_style += "U"
         styled_txt_frags = tuple(self._parse_chars(text, markdown))
         if markdown:
-            # Know problem:
-            # If a bold italic font is present (like courierBI) fpdf2 will add
-            # courierB, courierI and courierBI to the output pdf
             page = self.page
             # We set the current to page to zero so that
             # set_font() does not produce any text object on the stream buffer:
             self.page = 0
-            if any("B" in frag.font_style for frag in styled_txt_frags):
+            if any(frag.font_style == "B" for frag in styled_txt_frags):
                 # Ensuring bold font is supported:
                 self.set_font(style="B")
-            if any("I" in frag.font_style for frag in styled_txt_frags):
+            if any(frag.font_style == "I" for frag in styled_txt_frags):
                 # Ensuring italics font is supported:
                 self.set_font(style="I")
-            if any("BI" in frag.font_style for frag in styled_txt_frags):
+            if any(frag.font_style == "BI" for frag in styled_txt_frags):
                 # Ensuring bold italics font is supported:
                 self.set_font(style="BI")
-            if any("" in frag.font_style for frag in styled_txt_frags):
+            if any(frag.font_style == "" for frag in styled_txt_frags):
                 # Ensuring base font is supported:
                 self.set_font(style="")
             for frag in styled_txt_frags:

test/text/cell_markdown_bold_italic.pdf

@@ -173,6 +173,15 @@ def test_cell_markdown(tmp_path):
     assert_pdf_equal(pdf, HERE / "cell_markdown.pdf", tmp_path)
 
 
+def test_cell_markdown_bold_italic(tmp_path):
+    # issue 1094
+    pdf = FPDF()
+    pdf.add_page()
+    pdf.set_font("Times", size=60)
+    pdf.cell(text="**__Lorem --Ipsum--__**", markdown=True)
+    assert_pdf_equal(pdf, HERE / "cell_markdown_bold_italic.pdf", tmp_path)
+
+
 def test_cell_markdown_with_ttf_fonts(tmp_path):
     pdf = FPDF()
     pdf.add_page()