DEV: Sync pre-commit configuration with requirements (#3192)

Author: stefan6419846

.github/workflows/github-ci.yaml

@@ -184,6 +184,10 @@ jobs:
       run: |
         pip install -r requirements/docs.txt
         sphinx-build --nitpicky --fail-on-warning --keep-going --show-traceback --builder html docs build/sphinx/html
+    - name: Check with pre-commit
+      run: |
+        pip install -r requirements/dev.txt
+        pre-commit run --all-files --show-diff-on-failure
 
   package:
     name: Build & verify package

.pre-commit-config.yaml

@@ -4,13 +4,13 @@ repos:
     rev: v5.0.0
     hooks:
     -   id: check-ast
-    -   id: check-byte-order-marker
     -   id: check-case-conflict
     -   id: check-docstring-first
     -   id: check-yaml
     -   id: debug-statements
     -   id: end-of-file-fixer
         exclude: "resources/.*|docs/make.bat"
+    -   id: fix-byte-order-marker
     -   id: trailing-whitespace
     -   id: mixed-line-ending
         args: ['--fix=lf']
@@ -19,7 +19,7 @@ repos:
         args: ['--maxkb=1000']
 
 -   repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.7.0
+    rev: v0.10.0
     hooks:
     -   id: ruff
         args: ['--fix']
@@ -31,7 +31,7 @@ repos:
         args: [--py38-plus]
 
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: 'v1.13.0'
+    rev: 'v1.15.0'
     hooks:
       - id: mypy
         additional_dependencies: [types-Pillow==10.2.0.20240822]

docs/user/extract-attachments.md

@@ -27,4 +27,4 @@ reader = PdfReader("example.pdf")
 
 for attachment in reader.attachment_list:
     print(attachment.name, attachment.alternative_name, attachment.content)
-```
+```

pypdf/generic/_files.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Generator, Optional, cast
+from typing import TYPE_CHECKING, Generator, cast
 
 from pypdf._utils import parse_iso8824_date
 from pypdf.constants import FileSpecificationDictionaryEntries
@@ -29,7 +29,7 @@ def __init__(self, name: str, pdf_object: DictionaryObject) -> None:
         self.pdf_object = pdf_object
 
     @property
-    def alternative_name(self) -> Optional[str]:
+    def alternative_name(self) -> str | None:
         """Retrieve the alternative name (file specification)."""
         for key in [FileSpecificationDictionaryEntries.UF, FileSpecificationDictionaryEntries.F]:
             # PDF 2.0 reference, table 43:
@@ -39,7 +39,7 @@ def alternative_name(self) -> Optional[str]:
         return None
 
     @property
-    def description(self) -> Optional[str]:
+    def description(self) -> str | None:
         """Retrieve the description."""
         return self.pdf_object.get(FileSpecificationDictionaryEntries.DESC)
 
@@ -65,7 +65,7 @@ def _params(self) -> DictionaryObject:
         return self._embedded_file.get("/Params", DictionaryObject()).get_object()
 
     @property
-    def subtype(self) -> Optional[str]:
+    def subtype(self) -> str | None:
         """Retrieve the subtype. This is a MIME media type, prefixed by a slash."""
         return self._embedded_file.get("/Subtype")
 
@@ -75,30 +75,30 @@ def content(self) -> bytes:
         return self._embedded_file.get_data()
 
     @property
-    def size(self) -> Optional[int]:
+    def size(self) -> int | None:
         """Retrieve the size of the uncompressed file in bytes."""
         return self._params.get("/Size")
 
     @property
-    def creation_date(self) -> Optional[datetime.datetime]:
+    def creation_date(self) -> datetime.datetime | None:
         """Retrieve the file creation datetime."""
         return parse_iso8824_date(self._params.get("/CreationDate"))
 
     @property
-    def modification_date(self) -> Optional[datetime.datetime]:
+    def modification_date(self) -> datetime.datetime | None:
         """Retrieve the datetime of the last file modification."""
         return parse_iso8824_date(self._params.get("/ModDate"))
 
     @property
-    def checksum(self) -> Optional[bytes]:
+    def checksum(self) -> bytes | None:
         """Retrieve the MD5 checksum of the (uncompressed) file."""
         return self._params.get("/CheckSum")
 
     def __repr__(self) -> str:
         return f"<{self.__class__.__name__} name={self.name!r}>"
 
     @classmethod
-    def _load_from_names(cls, names: ArrayObject) -> Generator[EmbeddedFile, None, None]:
+    def _load_from_names(cls, names: ArrayObject) -> Generator[EmbeddedFile]:
         """
         Convert the given name tree into class instances.
 
@@ -117,7 +117,7 @@ def _load_from_names(cls, names: ArrayObject) -> Generator[EmbeddedFile, None, N
                 yield EmbeddedFile(name=direct_name, pdf_object=file_dictionary)
 
     @classmethod
-    def _load(cls, catalog: DictionaryObject) -> Generator[EmbeddedFile, None, None]:
+    def _load(cls, catalog: DictionaryObject) -> Generator[EmbeddedFile]:
         """
         Load the embedded files for the given document catalog.