DEV: Remove excluding Ruff rule RET507 (#3190)

RET507: Unnecessary "else"  or "elif" after "continue" statement.

Author: j-t-1

pypdf/_writer.py

@@ -2909,8 +2909,7 @@ def add_filtered_articles(
                 thr = a.get_object().get("/T")
                 if thr is None:
                     continue
-                else:
-                    thr = thr.get_object()
+                thr = thr.get_object()
                 if thr.indirect_reference.idnum not in self._id_translated[
                     id(reader)
                 ] and fltr.search((thr.get("/I", {})).get("/Title", "")):

pypdf/generic/_data_structures.py

@@ -336,8 +336,7 @@ def _clone(
                     del ignore_fields[x]
                     del ignore_fields[x]
                     continue
-                else:
-                    ignore_fields[x] -= 1  # type:ignore
+                ignore_fields[x] -= 1  # type:ignore
             x += 1
         #  First check if this is a chain list, we need to loop to prevent recur
         if any(
@@ -567,7 +566,7 @@ def read_unsized_from_stream(
             tok = read_non_whitespace(stream)
             if tok == b"\x00":
                 continue
-            elif tok == b"%":
+            if tok == b"%":
                 stream.seek(-1, 1)
                 skip_over_comment(stream)
                 continue

pypdf/generic/_image_inline.py

@@ -159,8 +159,7 @@ def extract_inline_DCT(stream: StreamType) -> bytes:
             data_out += c
         if c != b"\xff":
             continue
-        else:
-            notfirst = True
+        notfirst = True
         c = stream.read(1)
         data_out += c
         if c == b"\xff":

pypdf/generic/_utils.py

@@ -103,7 +103,7 @@ def read_string_from_stream(
                     else:
                         txt.append(i)
                     continue
-                elif tok in b"\n\r":
+                if tok in b"\n\r":
                     # This case is hit when a backslash followed by a line
                     # break occurs. If it's a multi-char EOL, consume the
                     # second character:
@@ -113,10 +113,9 @@ def read_string_from_stream(
                     # Then don't add anything to the actual string, since this
                     # line break was escaped:
                     continue
-                else:
-                    msg = f"Unexpected escaped string: {tok.decode('utf-8','ignore')}"
-                    logger_warning(msg, __name__)
-                    txt.append(__BACKSLASH_CODE__)
+                msg = f"Unexpected escaped string: {tok.decode('utf-8', 'ignore')}"
+                logger_warning(msg, __name__)
+                txt.append(__BACKSLASH_CODE__)
         txt.append(ord(tok))
     return create_string_object(bytes(txt), forced_encoding)
 

pyproject.toml

@@ -182,7 +182,6 @@ ignore = [
     "RET504",  # Unnecessary assignment to `changelog` before `return`
     "RET505",  # Unnecessary `else` after `return` statement
     "RET506",  # Unnecessary `else` after `raise` statement
-    "RET507",  # Unnecessary `else` after `continue` statement
     "RUF001",  # Detect confusable Unicode-to-Unicode units. Introduces bugs
     "RUF002",  # Detect confusable Unicode-to-Unicode units. Introduces bugs
     "S101",    # Use of `assert` detected