Skip to content

Commit cf0ceba

Browse files
committed
Fix: style cleanup
1 parent e754247 commit cf0ceba

11 files changed

+222
-178
lines changed

_includes/package-grid.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ <h3 class="card__title no_toc" itemprop="name">
2828
{% endif %}
2929
</span>
3030
</p>
31-
<span class="narrow">
32-
<p class="archive__item-excerpt narrow" itemprop="description">
31+
<span class="package_description">
32+
<p itemprop="description">
3333
{{ apackage.package_description | markdownify }}
3434
</p>
3535
</span>

_pages/home.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ peer-review:
103103
<!-- pull blog posts not events -->
104104
{% assign blog_posts = site.posts | where_exp: "item", "item.categories contains 'blog-post'" %}
105105

106-
<div class="notice notice-highlight" markdown="1">
106+
<div class="notice" markdown="1">
107107

108108
## Recent blog posts & updates
109109

@@ -135,7 +135,7 @@ peer-review:
135135
{% assign packages_sorted = site.data.packages | sort_natural: 'date_accepted' | reverse %}
136136

137137
<div class="grid">
138-
{% for apackage in packages_sorted limit:4 %}
138+
{% for apackage in packages_sorted limit:3 %}
139139
{% include package-grid.html %}
140140
{% endfor %}
141141
</div>

_posts/2019-10-26-pyos-min-mistakes-theme.md

+26-6
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ toc: true
1111
categories:
1212
- docs
1313
- blog-post
14+
classes: wide
1415
---
1516

1617

@@ -300,22 +301,22 @@ Call attention to a block of text.
300301
| Success | `.notice--success` |
301302
| Danger | `.notice--danger` |
302303

303-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice}` class. The purpose of this test paragraph is to check how different styles are applied across various sections of text. You can [highlight](#) certain words or phrases, adjust the [font size](#), or change the [text color](#) to see how the styling adapts. Additionally, experimenting with [different classes](#) and observing the effects on alignment, spacing, and other typographic elements will help ensure that your CSS is applied consistently and effectively across your site.
304+
**Technical and social skills go hand in hand.** Open source communities are most productive when contributors and maintainers recognize this balance between the technical and social skills associated with contributing. In most cases, all of the people involved in the project are volunteers with varying priorities, skillsets, and motivations to participate.
304305
{: .notice}
305306

306-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice--primary}` class.
307+
**Watch out!** This paragraph of text has been emphasized with the `{: .notice--primary}` class.
307308
{: .notice--primary}
308309

309-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice--info}` class.
310+
**Watch out!** This paragraph of text has been emphasized with the `{: .notice--info}` class.
310311
{: .notice--info}
311312

312-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice--warning}` class.
313+
**Watch out!** This paragraph of text has been emphasized with the `{: .notice--warning}` class.
313314
{: .notice--warning}
314315

315-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice--success}` class.
316+
**Watch out!** This paragraph of text has been emphasized with the `{: .notice--success}` class.
316317
{: .notice--success}
317318

318-
**Watch out!** This paragraph of text has been [emphasized](#) with the `{: .notice--danger}` class.
319+
**Watch out!** This paragraph of text has been emphasized with the `{: .notice--danger}` class.
319320
{: .notice--danger}
320321

321322
<div class="notice" markdown="1">
@@ -350,6 +351,25 @@ Which will render like this
350351
</div>
351352

352353

354+
<div class="notice--info" markdown="1">
355+
#### Notice Headline
356+
{: .no_toc }
357+
358+
here is some html text.
359+
360+
Testing a div with a h4 header
361+
362+
````html
363+
<div class="notice--info" markdown="1">
364+
#### Notice Headline
365+
{: .no_toc }
366+
367+
This is how you generate a div using markdown
368+
369+
</div>
370+
````
371+
</div>
372+
353373

354374

355375
Using the Kramdown Markdown renderer with Jekyll allows you to add [block](http://kramdown.gettalong.org/quickref.html#block-attributes) and [inline attributes](http://kramdown.gettalong.org/quickref.html#inline-attributes). This is nice if you want to add custom styling to text and image, and still write in Markdown.

_sass/minimal-mistakes/_base.scss

+4-2
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,10 @@
150150

151151
%quote-style {
152152
font-weight: bold;
153-
font-size: 100px;
153+
//font-size: $type-size-2;
154154
color: $pyos-teal;
155155
line-height: 0;
156+
font-size: 5rem;
156157
}
157158

158159
/* Block quote with bigger quotes*/
@@ -190,7 +191,8 @@
190191
}
191192

192193
p {
193-
font-size: 1.3rem;
194+
font-size: $type-size-3;
195+
line-height: 2.8rem;
194196
position: relative;
195197
margin-bottom: 0.63rem;
196198

_sass/minimal-mistakes/_notices.scss

+62-64
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,67 @@
1010
* </div>
1111
*/
1212

13+
14+
15+
/* Notice elements with figures */
16+
.notice {
17+
18+
19+
20+
h2, h3 {
21+
margin-top: 0 !important;
22+
}
23+
24+
figcaption {
25+
font-family: $body-font;
26+
font-size: 1.2em; // This will override the previous 1.3em
27+
}
28+
29+
&--info {
30+
.btn.btn--info {
31+
color: #fff;
32+
}
33+
34+
.archive__item-excerpt {
35+
font-size: 0.95em;
36+
}
37+
38+
h2 {
39+
font-size: 1.5em;
40+
}
41+
42+
h3 a,
43+
h2 a:visited {
44+
font-size: 1.5em;
45+
text-decoration: none;
46+
}
47+
}
48+
}
49+
50+
1351
@mixin notice($notice-color) {
14-
margin: 2em 0 !important; /* override*/
15-
padding: 1em;
52+
margin: 2rem 0 !important; /* override*/
53+
padding: 3rem;
1654
color: $text-color;
1755
font-family: $global-font-family;
18-
font-size: $type-size-6 !important;
56+
font-size: $type-size-4 !important;
57+
font-weight: 300!important;
1958
text-indent: initial; /* override*/
2059
background-color: mix($background-color, $notice-color, $notice-background-mix);
2160
border-radius: $border-radius;
22-
box-shadow: 0 1px 1px rgba($notice-color, 0.25);
61+
box-shadow: 0 1px 1px rgba(darken($notice-color, 20%), 0.25);
62+
line-height: 1.7rem!important;
63+
64+
// We might want a header like element in a notice but not an actual h4 etc
65+
// this style mimicks a header within a notice block.
66+
.header {
67+
font-size: 1.5rem!important;
68+
font-weight: 700;
69+
margin-bottom: 1rem;
70+
}
2371

2472
h4 {
25-
margin-top: 0 !important; /* override*/
73+
margin-top: 0 !important;
2674
margin-bottom: 0.75em;
2775
line-height: inherit;
2876
}
@@ -33,7 +81,14 @@
3381
font-size: 1.6em;
3482
}
3583

84+
p, li {
85+
font-size: $type-size-6!important;
86+
font-weight: 300;
87+
}
88+
3689
p {
90+
line-height: 1.6rem;
91+
3792
&:last-child {
3893
margin-bottom: 0 !important; /* override*/
3994
}
@@ -81,11 +136,6 @@
81136
@include notice($light-gray);
82137
}
83138

84-
.notice .header {
85-
font-size: 1.5rem!important;
86-
font-weight: 700;
87-
margin-bottom: 1rem;
88-
}
89139

90140
/* Primary notice */
91141

@@ -117,15 +167,6 @@
117167
@include notice($danger-color);
118168
}
119169

120-
.notice-highlight {
121-
background-color: $background-block;
122-
padding: 1em;
123-
124-
h2 {
125-
margin-top: 1em;
126-
}
127-
}
128-
129170
/* Quotes in notice blocks */
130171

131172
.notice blockquote {
@@ -134,12 +175,13 @@
134175
max-width: 100%;
135176

136177
&.highlight-quote {
137-
margin: 7em .5em;
178+
margin: 3rem .5em;
138179
padding: 0;
139180
max-width: $medium;
140181

141182
p {
142183
margin-bottom: 1rem;
184+
font-size: 1.5rem!important;
143185
}
144186
&::after {
145187
margin: 2rem;
@@ -151,50 +193,6 @@
151193
}
152194
}
153195

154-
/* Notice elements with figures */
155-
.notice {
156-
border-radius: 15px !important;
157-
box-shadow: 0 1px 1px rgba(189, 193, 196, 0.25) !important;
158-
padding: 3rem;
159-
160-
font-size: 1.7rem !important;
161-
font-weight: 700;
162-
margin-bottom: 1rem;
163-
164-
p, li {
165-
font-size: 1.1rem!important;
166-
}
167-
168-
h2, h3 {
169-
margin-top: 0 !important;
170-
}
171-
172-
figcaption {
173-
font-family: $body-font;
174-
font-size: 1.2em; // This will override the previous 1.3em
175-
}
176-
177-
&--info {
178-
.btn.btn--info {
179-
color: #fff;
180-
}
181-
182-
.archive__item-excerpt {
183-
font-size: 0.95em;
184-
}
185-
186-
h2 {
187-
font-size: 1.5em;
188-
}
189-
190-
h3 a,
191-
h2 a:visited {
192-
font-size: 1.5em;
193-
text-decoration: none;
194-
}
195-
}
196-
}
197-
198196

199197
/* max 480 px */
200198
@media screen and (max-width: 480px) {

0 commit comments

Comments
 (0)