Update tests for DOUBLE type support in SQLAlchemy 2.0+

Update test assertions to use get_double_type() for version-compatible
type checking, and remove outdated TODO comments.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: laughingman7743

tests/pyathena/sqlalchemy/test_base.py

@@ -18,7 +18,14 @@
 from sqlalchemy.sql.schema import Column, MetaData, Table
 from sqlalchemy.sql.selectable import TextualSelect
 
-from pyathena.sqlalchemy.types import TINYINT, AthenaArray, AthenaMap, AthenaStruct, Tinyint
+from pyathena.sqlalchemy.types import (
+    TINYINT,
+    AthenaArray,
+    AthenaMap,
+    AthenaStruct,
+    Tinyint,
+    get_double_type,
+)
 from tests.pyathena.conftest import ENV
 
 
@@ -507,8 +514,7 @@ def test_reflect_select(self, engine):
         assert isinstance(one_row_complex.c.col_int.type, types.INTEGER)
         assert isinstance(one_row_complex.c.col_bigint.type, types.BIGINT)
         assert isinstance(one_row_complex.c.col_float.type, types.FLOAT)
-        # TODO: types.DOUBLE is not defined in SQLAlchemy 1.4.
-        assert isinstance(one_row_complex.c.col_double.type, types.FLOAT)
+        assert isinstance(one_row_complex.c.col_double.type, get_double_type())
         assert isinstance(one_row_complex.c.col_string.type, types.String)
         assert isinstance(one_row_complex.c.col_varchar.type, types.VARCHAR)
         assert one_row_complex.c.col_varchar.type.length == 10
@@ -558,8 +564,7 @@ def test_get_column_type(self, engine):
         assert isinstance(dialect._get_column_type("int"), types.INTEGER)
         assert isinstance(dialect._get_column_type("bigint"), types.BIGINT)
         assert isinstance(dialect._get_column_type("float"), types.FLOAT)
-        # TODO: types.DOUBLE is not defined in SQLAlchemy 1.4.
-        assert isinstance(dialect._get_column_type("double"), types.FLOAT)
+        assert isinstance(dialect._get_column_type("double"), get_double_type())
         assert isinstance(dialect._get_column_type("real"), types.FLOAT)
         assert isinstance(dialect._get_column_type("string"), types.String)
         assert isinstance(dialect._get_column_type("varchar"), types.VARCHAR)
@@ -2145,30 +2150,12 @@ def test_numeric_type_variants(self, engine):
         assert type(actual.c.col_integer2.type) in [types.INT, types.INTEGER, types.Integer]
         assert type(actual.c.col_bigint.type) in [types.BIGINT, types.BigInteger]
         assert type(actual.c.col_biginteger.type) in [types.BIGINT, types.BigInteger]
-        assert type(actual.c.col_double1.type) in [types.FLOAT, types.Float]
-        assert type(actual.c.col_double2.type) in [types.FLOAT, types.Float]
-        assert type(actual.c.col_double_precision.type) in [types.FLOAT, types.Float]
-        # TODO: types.DOUBLE is not defined in SQLAlchemy 1.4.
-        # assert type(actual.c.col_double_precision.type) in [
-        #     types.DOUBLE,
-        #     types.Double,
-        #     types.DOUBLE_PRECISION,
-        # ]
-        # assert type(actual.c.col_double1.type) in [
-        #     types.DOUBLE,
-        #     types.Double,
-        #     types.DOUBLE_PRECISION,
-        # ]
-        # assert type(actual.c.col_double2.type) in [
-        #     types.DOUBLE,
-        #     types.Double,
-        #     types.DOUBLE_PRECISION,
-        # ]
-        # assert type(actual.c.col_double_precision.type) in [
-        #     types.DOUBLE,
-        #     types.Double,
-        #     types.DOUBLE_PRECISION,
-        # ]
+        expected_double_types = [types.FLOAT, types.Float]
+        if hasattr(types, "DOUBLE"):
+            expected_double_types.extend([types.DOUBLE, types.Double, types.DOUBLE_PRECISION])
+        assert type(actual.c.col_double1.type) in expected_double_types
+        assert type(actual.c.col_double2.type) in expected_double_types
+        assert type(actual.c.col_double_precision.type) in expected_double_types
         assert type(actual.c.col_float1.type) in [types.FLOAT, types.Float]
         assert type(actual.c.col_float2.type) in [types.FLOAT, types.Float]
         assert type(actual.c.col_decimal.type) in [types.DECIMAL]