Skip to content

Commit d9fc558

Browse files
committed
#ifdef out entire wrap() function to avoid unused-parameter warning-as-error under macos-13
``` /Users/runner/work/pybind11/pybind11/tests/test_class_sh_trampoline_basic.cpp:67:23: error: unused parameter 'm' [-Werror,-Wunused-parameter] void wrap(py::module_ m, const char *py_class_name) { ^ /Users/runner/work/pybind11/pybind11/tests/test_class_sh_trampoline_basic.cpp:67:38: error: unused parameter 'py_class_name' [-Werror,-Wunused-parameter] void wrap(py::module_ m, const char *py_class_name) { ^ 2 errors generated. ```
1 parent 8d771c4 commit d9fc558

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/test_class_sh_trampoline_basic.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ int AddInCppUniquePtr(std::unique_ptr<Abase<SerNo>> obj, int other_val) {
6363
return obj->Add(other_val) * 100 + 13;
6464
}
6565

66+
#ifdef PYBIND11_SMART_HOLDER_ENABLED
6667
template <int SerNo>
6768
void wrap(py::module_ m, const char *py_class_name) {
68-
#ifdef PYBIND11_SMART_HOLDER_ENABLED
6969
py::classh<Abase<SerNo>, AbaseAlias<SerNo>>(m, py_class_name)
7070
.def(py::init<int>(), py::arg("val"))
7171
.def("Get", &Abase<SerNo>::Get)
@@ -74,8 +74,8 @@ void wrap(py::module_ m, const char *py_class_name) {
7474
m.def("AddInCppRawPtr", AddInCppRawPtr<SerNo>, py::arg("obj"), py::arg("other_val"));
7575
m.def("AddInCppSharedPtr", AddInCppSharedPtr<SerNo>, py::arg("obj"), py::arg("other_val"));
7676
m.def("AddInCppUniquePtr", AddInCppUniquePtr<SerNo>, py::arg("obj"), py::arg("other_val"));
77-
#endif
7877
}
78+
#endif
7979

8080
} // namespace class_sh_trampoline_basic
8181
} // namespace pybind11_tests

0 commit comments

Comments
 (0)