|
1 | | -How to Contribute |
2 | | -================= |
3 | | - |
4 | | - The `f2format` project is an open source Python program focus on |
5 | | -conversion between *f-string* and `str.format`. |
6 | | - |
7 | | -Pull Requests |
8 | | -------------- |
9 | | - |
10 | | -1. Pull requests are welcome. If you would like to add a large feature |
11 | | - or make a significant change, make sure to open an issue to discuss |
12 | | - with other people first. |
13 | | -2. Follow PEP8. |
14 | | -3. Make sure to pass the unit tests. Write unit tests for new modules if |
15 | | - needed. |
16 | | - |
17 | | -Issues |
18 | | ------- |
19 | | - |
20 | | -1. Only bugs and feature requests are accepted here. |
21 | | -2. Shall only work on important features. If the feature you're asking |
22 | | - only benefits a few people, you'd better implement the featur |
23 | | - yourself and send us a pull request, or ask some of your friends to |
24 | | - do so. |
25 | | -3. Don't answer questions of any other types here, but tips and some |
26 | | - troubleshooting on Python can be found here. |
27 | | -4. Issues in languages other than English and Chinese will be Google |
28 | | - translated into English later. |
| 1 | +# How to contribute |
| 2 | + |
| 3 | +This document outlines some of the conventions on development workflow, commit message formatting, contact points and other |
| 4 | +resources to make it easier to get your contribution accepted. |
| 5 | + |
| 6 | +## Getting started |
| 7 | + |
| 8 | +- Fork the repository on GitHub. |
| 9 | +- Read the README.md for build instructions. |
| 10 | +- Play with the project, submit bugs, submit patches! |
| 11 | + |
| 12 | +## Contribution flow |
| 13 | + |
| 14 | +This is a rough outline of what a contributor's workflow looks like: |
| 15 | + |
| 16 | +- Create a topic branch from where you want to base your work. This is usually master. |
| 17 | +- Make commits of logical units and add test case if the change fixes a bug or adds new functionality. |
| 18 | +- Run tests and make sure all the tests are passed. |
| 19 | +- Make sure your commit messages are in the proper format (see below). |
| 20 | +- Push your changes to a topic branch in your fork of the repository. |
| 21 | +- Submit a pull request to the repo. |
| 22 | + |
| 23 | +Thanks for your contributions! |
| 24 | + |
| 25 | +## Coding Style |
| 26 | + |
| 27 | +See the [Python style doc](https://www.python.org/dev/peps/pep-0008/) for details. |
| 28 | + |
| 29 | +### Format of the Commit Message |
| 30 | + |
| 31 | +We follow a rough convention for commit messages that is designed to answer two |
| 32 | +questions: what changed and why. The subject line should feature the what and |
| 33 | +the body of the commit should describe the why. |
| 34 | + |
| 35 | +<pre><code> |
| 36 | +store/localstore: add comment for variable declaration. |
| 37 | + |
| 38 | +Improve documentation. |
| 39 | +</code></pre> |
| 40 | + |
| 41 | +The format can be described more formally as follows: |
| 42 | + |
| 43 | +<pre><code> |
| 44 | +subsystem: what changed |
| 45 | +BLANK LINE |
| 46 | +why this change was made |
| 47 | +BLANK LINE |
| 48 | +footer(optional) |
| 49 | +</code></pre> |
| 50 | + |
| 51 | +The first line is the subject and should be no longer than 70 characters, the |
| 52 | +second line is always blank, and other lines should be wrapped at 80 characters. |
| 53 | +This allows the message to be easier to read on GitHub as well as in various |
| 54 | +git tools. |
| 55 | + |
| 56 | +If the change affects more than one subsystem, you can use comma to separate them like util/codec,util/types:. |
| 57 | + |
| 58 | +If the change affects many subsystems, you can use * instead, like *:. |
| 59 | + |
| 60 | +For the why part, if no specific reason for the change, |
| 61 | +you can use one of some generic reasons like "Improve documentation.", |
| 62 | +"Improve performance.", "Improve robustness.", "Improve test coverage." |
| 63 | + |
| 64 | + |
| 65 | +###### Auto generated by [gaocegege/maintainer](https://github.com/gaocegege/maintainer) on 2018-12-06 |
0 commit comments