-
Notifications
You must be signed in to change notification settings - Fork 110
/
Copy pathviews.py
375 lines (338 loc) · 13.2 KB
/
views.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
import collections
import json
import random
from django.conf import settings
from django.conf.global_settings import DATETIME_INPUT_FORMATS
from django.core.exceptions import ValidationError
from django.contrib.auth.mixins import PermissionRequiredMixin
from django.contrib import messages
from django.urls import reverse
from django.db.models import Count
from django.http import Http404
from django.shortcuts import redirect, render
from django.views.generic import ListView, UpdateView
from core.utils import SequenceQuerySet
from proposals.models import TalkProposal
from .forms import ReviewForm
from .models import REVIEW_REQUIRED_PERMISSIONS, Review, TalkProposalSnapshot
from .context import reviews_state
from registry.helper import reg
import pytz
import datetime
class ReviewableMixin:
def dispatch(self, request, *args, **kwargs):
self.reviews_state = reviews_state()
if self.reviews_state.reviews_stage < 1:
raise Http404
return super().dispatch(request, *args, **kwargs)
class TalkProposalListView(ReviewableMixin, PermissionRequiredMixin, ListView):
model = TalkProposal
permission_required = REVIEW_REQUIRED_PERMISSIONS
template_name = 'reviews/talk_proposal_list.html'
vote_keys = {
Review.Vote.PLUS_ONE: 'strong_accept',
Review.Vote.PLUS_ZERO: 'weak_accept',
Review.Vote.MINUS_ZERO: 'weak_reject',
Review.Vote.MINUS_ONE: 'strong_reject',
}
order_keys = {
'title': 'title',
'count': 'review_count',
'category': 'category',
'level': 'python_level',
'lang': 'language',
'-title': '-title',
'-count': '-review_count',
'-category': '-category',
'-level': '-python_level',
'-lang': '-language',
}
paginate_by = 100
def get_ordering(self):
params = self.request.GET
order_key = self.order_keys.get(params.get('order', '').lower())
return order_key or '?'
def get_queryset(self):
user = self.request.user
qs = (
super().get_queryset()
.filter_reviewable(user)
.exclude(accepted__isnull=False)
.exclude(review__reviewer=user)
.annotate(review_count=Count('review'))
)
# params = self.request.GET
# category = params.get('category', '').upper()
# if category:
# proposals = proposals.filter(category=category)
ordering = self.get_ordering()
if ordering == '?':
# We don't use order_by('?') because it is crazy slow, and instead
# resolve the queryset to a list, and shuffle it normally. This is
# OK since we will iterate through it in the template anyway.
# Note: This order by is necessary to override the default
# ordering, and add an appropriate DISTINCT on the query. This
# is caused by a Django logic error regarding how ORDER BY
# contributes to GROUP BY.
proposal_list = list(qs.order_by('pk'))
random.shuffle(proposal_list)
qs = SequenceQuerySet(proposal_list)
ordering = '?'
else:
qs = qs.order_by(ordering)
self.ordering = ordering
return qs
def get_context_data(self, **kwargs):
review_stage = self.reviews_state.reviews_stage
verdicted_proposals = (
TalkProposal.objects
.filter_reviewable(self.request.user)
.filter(accepted__isnull=False)
.annotate(review_count=Count('review'))
)
vote_count_pairs = (
self.get_reviews()
# This transform is needed to clear the default ordering in
# the model. The default ordering contributes to GROUP BY, and
# breaks the COUNT aggregation.
.order_by()
.values_list('vote')
.annotate(count=Count('vote'))
)
vote_mapping = collections.defaultdict(
(lambda: 0),
((self.vote_keys[k], v)
for k, v in vote_count_pairs
if k in self.vote_keys),
)
context = super().get_context_data(**kwargs)
context.update({
'proposals_with_verdict': verdicted_proposals,
'reviews': self.get_reviews(),
'review_stage': review_stage,
'review_stage_desc_tpl': (
'reviews/_includes/review_stage_%s_desc.html'
% review_stage
),
'vote': vote_mapping,
'ordering': self.ordering,
'query_string': self.request.GET.urlencode(),
**self.reviews_state._asdict(),
})
return context
def get_reviews(self):
review_stage = self.reviews_state.reviews_stage
if review_stage == 1:
reviews = (
Review.objects
.select_related('proposal')
.filter_reviewable(self.request.user)
.exclude(stage=2)
)
elif review_stage == 2:
proposals = (
TalkProposal.objects.filter(
review__stage=1,
review__reviewer=self.request.user
) & TalkProposal.objects.filter(
review__stage=2,
review__reviewer=self.request.user
)
)
reviews = (
Review.objects
.select_related('proposal')
.filter_reviewable(self.request.user)
.filter(proposal__accepted__isnull=True)
.exclude(proposal__in=proposals, stage=1)
)
return reviews
class ReviewEditView(ReviewableMixin, PermissionRequiredMixin, UpdateView):
form_class = ReviewForm
permission_required = REVIEW_REQUIRED_PERMISSIONS
template_name = 'reviews/review_form.html'
proposal_model = TalkProposal
snapshot_model = TalkProposalSnapshot
def get_proposal(self):
try:
proposal = (
self.proposal_model.objects
.filter_reviewable(self.request.user)
.get(pk=self.kwargs['proposal_pk'])
)
except self.proposal_model.DoesNotExist:
raise Http404
return proposal
def get_snapshot(self, proposal):
try:
snapshot = (
self.snapshot_model.objects
.filter(
proposal=proposal,
stage__lt=self.reviews_state.reviews_stage
)
.latest('dumped_at')
)
except self.snapshot_model.DoesNotExist:
return None
try:
snapshot = TalkProposal(**json.loads(snapshot.dumped_json))
except (TypeError, ValueError):
return None
return snapshot
def get(self, request, *args, **kwargs):
self.proposal = self.get_proposal()
return super().get(request, *args, **kwargs)
def post(self, request, *args, **kwargs):
self.proposal = self.get_proposal()
if self.proposal.accepted is not None:
return self.http_method_not_allowed(request, *args, **kwargs)
return super().post(request, *args, **kwargs)
def get_object(self):
try:
review = Review.objects.get(
proposal=self.proposal,
reviewer=self.request.user,
stage=self.reviews_state.reviews_stage,
)
except Review.DoesNotExist:
review = None
return review
def get_form_kwargs(self):
kwargs = super().get_form_kwargs()
kwargs.update({
'request': self.request,
'proposal': self.proposal,
})
if kwargs.get('instance') is not None or kwargs.get('initial'):
return kwargs
try:
review = Review.objects.get(
proposal=self.proposal,
reviewer=self.request.user,
stage=self.reviews_state.reviews_stage - 1,
)
except Review.DoesNotExist:
return kwargs
kwargs['initial'] = {
'vote': review.vote,
'comment': review.comment,
'note': review.note,
'discloses_comment': review.discloses_comment,
}
return kwargs
def get_context_data(self, **kwargs):
review_stage = self.reviews_state.reviews_stage
# Query all reviews made by others, including all stages
other_review_iter = (
Review.objects
.filter_current_reviews(
proposal=self.proposal,
exclude_user=self.request.user,
)
.iter_reviewer_latest_reviews()
)
# Sort other_reviews by vote.
other_reviews = sorted(
other_review_iter,
key=lambda r: Review.VOTE_ORDER[r.vote],
)
my_reviews = (
Review.objects
.filter_current_reviews(
proposal=self.proposal,
filter_user=self.request.user,
)
.order_by('stage')
)
if self.proposal.accepted is None and self.object:
# If this proposal does not have verdict, this page will have a
# review form. Exclude the current user's current review so that
# it does not show up twice (once in the table, once in form).
my_reviews = my_reviews.exclude(pk=self.object.pk)
kwargs.update({
'proposal': self.proposal,
'snapshot': self.get_snapshot(self.proposal),
'other_reviews': other_reviews,
'my_reviews': my_reviews,
'review_stage': review_stage,
**self.reviews_state._asdict(),
})
return super().get_context_data(**kwargs)
def get_success_url(self):
query_string = self.request.GET.urlencode()
url = reverse('review_proposal_list')
if query_string:
return url + '?' + query_string
return url
def review_stages(request):
current_review_stages_setting = {}
review_stages_list = [
'Call for Proposals',
'Locked (proposal editing and reviewing disabled)',
'First Round Review', 'Modification Stage', 'Second Round Review',
'Internal Decision', 'Announcement of Acceptance'
]
review_stages_var = [
'proposals.creatable', 'proposals.editable', 'proposals.withdrawable',
'reviews.visible.to.submitters', 'reviews.stage',
'proposals.disable.after'
]
if request.method == 'POST':
for tag in review_stages_var:
key = settings.CONFERENCE_DEFAULT_SLUG + '.' + tag
if (tag == 'proposals.disable.after'):
if(request.POST['proposals.disable.after'] == ""):
continue
else:
date_time_obj = date_preprocess(
DATETIME_INPUT_FORMATS,
request.POST['proposals.disable.after'])
if(date_time_obj is None):
messages.error(request,'Please input valid date format : " + "%Y-%m-%dT%H:%M')
return render(
request, 'reviews/review_stages.html', {
'timezones': pytz.common_timezones,
'review_stages_list': review_stages_list,
'current_review_stages_setting': current_review_stages_setting,
**reviews_state()._asdict()
})
continue
else:
tz_selectd = pytz.timezone(request.POST['review_timezone'])
loc_dt = tz_selectd.localize(date_time_obj).strftime(
'%Y-%m-%d %H:%M:%S%z')
value = loc_dt
elif (tag == 'reviews.stage'):
value = int(request.POST[tag])
else:
value = request.POST[tag]
reg[key] = value
messages.info(request, 'This setting has been changed successfully.')
# Render current setting to frontend
for tag in review_stages_var:
key = settings.CONFERENCE_DEFAULT_SLUG + '.' + tag
value = reg.get(key, '')
# Django template language does not support dictionary keys containing "."
if "." in tag:
tag = tag.replace(".", "_")
current_review_stages_setting[tag] = value
return render(
request, 'reviews/review_stages.html', {
'timezones': pytz.common_timezones,
'review_stages_list': review_stages_list,
'current_review_stages_setting': current_review_stages_setting,
**reviews_state()._asdict()
})
def date_preprocess(DATETIME_INPUT_FORMATS, value):
# Add defined datetime formatx
DATETIME_INPUT_FORMATS += ['%Y-%m-%dT%H:%M:%S', '%Y-%m-%dT%H:%M']
value = value.strip()
# Try to strptime against each input format.
for format in DATETIME_INPUT_FORMATS:
try:
return datetime.datetime.strptime(value, format)
except (ValueError, TypeError):
continue
return None
# raise ValidationError("Please input valid date format : " + "%Y-%m-%dT%H:%M")