The announcement dismissal feature added in #2287 seems to store only the date of the dismissal, not the actual text that was dismissed. I think this means that updating to a new announcement does not automatically show the announcement banner again - instead the dismissal timeout controls when the banner is shown again.
I think it would be better to align the dismissal with the announcement text rather than a fixed time period. We could store the announcement text dismissed (or a hash), and compare the current text with the dismissed text to decide if we should show the banner. Then when the announcement is updated, the banner is automatically shown again, and once a user dismisses a particular announcement, it doesn't come back 2 weeks later.
I'll note that these concerns are called out as questions in #2287.
The announcement dismissal feature added in #2287 seems to store only the date of the dismissal, not the actual text that was dismissed. I think this means that updating to a new announcement does not automatically show the announcement banner again - instead the dismissal timeout controls when the banner is shown again.
I think it would be better to align the dismissal with the announcement text rather than a fixed time period. We could store the announcement text dismissed (or a hash), and compare the current text with the dismissed text to decide if we should show the banner. Then when the announcement is updated, the banner is automatically shown again, and once a user dismisses a particular announcement, it doesn't come back 2 weeks later.
I'll note that these concerns are called out as questions in #2287.