Apply ruff/refurb rule FURB113

Use `s.extend(...)` instead of repeatedly calling `s.append()`

Manual changes applied instead.

Author: DimitriPapadopoulos

pynetdicom/pdu.py

@@ -1093,21 +1093,22 @@ def reserved_aet(self, value: str | bytes) -> None:
 
     def __str__(self) -> str:
         """Return a string representation of the PDU."""
-        s = ["A-ASSOCIATE-AC PDU"]
-        s.append("==================")
-        s.append(f"  PDU type: 0x{self.pdu_type:02X}")
-        s.append(f"  PDU length: {self.pdu_length} bytes")
-        s.append(f"  Protocol version: {self.protocol_version}")
-        s.append(f"  Reserved (Called AET):  {self._reserved_aet}")
-        s.append(f"  Reserved (Calling AET): {self._reserved_aec}")
-        s.append("")
+        s = [
+            "A-ASSOCIATE-AC PDU",
+            "==================",
+            f"  PDU type: 0x{self.pdu_type:02X}",
+            f"  PDU length: {self.pdu_length} bytes",
+            f"  Protocol version: {self.protocol_version}",
+            f"  Reserved (Called AET):  {self._reserved_aet}",
+            f"  Reserved (Calling AET): {self._reserved_aec}",
+            "",
+            "  Variable Items:",
+            "  ---------------",
+            "  * Application Context Item",
+            f"    -  Context name: ={self.application_context_name}",
+        ]
 
-        s.append("  Variable Items:")
-        s.append("  ---------------")
-        s.append("  * Application Context Item")
-        s.append(f"    -  Context name: ={self.application_context_name}")
         s.append("  * Presentation Context Item(s):")
-
         for cx in self.presentation_context:
             item_str_list = str(cx).split("\n")
             s.append(f"    -  {item_str_list[0]}")

pynetdicom/pdu_items.py

@@ -1342,10 +1342,12 @@ def item_length(self) -> int:
 
     def __str__(self) -> str:
         """Return a string representation of the Item."""
-        s = ["Abstract Syntax Sub-item"]
-        s.append(f"  Item type: 0x{self.item_type:02X}")
-        s.append(f"  Item length: {self.item_length} bytes")
-        s.append(f"  Syntax name: ={self.abstract_syntax.name}")  # type: ignore
+        s = [
+            "Abstract Syntax Sub-item",
+            f"  Item type: 0x{self.item_type:02X}",
+            f"  Item length: {self.item_length} bytes",
+            f"  Syntax name: ={self.abstract_syntax.name}",  # type: ignore
+        ]
 
         return "\n".join(s)
 
@@ -1466,9 +1468,11 @@ def item_length(self) -> int:
 
     def __str__(self) -> str:
         """Return a string representation of the Item."""
-        s = ["Transfer syntax sub item"]
-        s.append(f"  Item type: 0x{self.item_type:02X}")
-        s.append(f"  Item length: {self.item_length} bytes")
+        s = [
+            "Transfer syntax sub item",
+            f"  Item type: 0x{self.item_type:02X}",
+            f"  Item length: {self.item_length} bytes",
+        ]
         if self.transfer_syntax_name:
             s.append(f"  Transfer syntax name: ={self.transfer_syntax_name.name}")
 
@@ -3441,14 +3445,15 @@ def message_control_header_byte(self) -> str:
 
     def __str__(self) -> str:
         """Return a string representation of the Item."""
-        s = ["Presentation Value Data Item"]
-        s.append(f"  Item length: {self.item_length} bytes")
-        s.append(f"  Context ID: {self.presentation_context_id}")
-
-        pdv_sample = [
+        pdv_samples = ' '.join(
             f"0x{b:02X}" for b in self.presentation_data_value[:10]  # type: ignore
+        )
+        s = [
+            "Presentation Value Data Item",
+            f"  Item length: {self.item_length} bytes",
+            f"  Context ID: {self.presentation_context_id}",
+            f"  Data value: {pdv_samples} ...",
         ]
-        s.append(f"  Data value: {' '.join(pdv_sample)} ...")
 
         return "\n".join(s)