Meaning of dseqrecord ipython test

[manulera]

Hi @BjornFJohansson,

This test is making some other new tests fail by reloading dseqrecord. Reloading the module means that isinstance fails when checking if something is a Dseqrecord as it is comparing the previous class with the reloaded class. What does it test and could it be tested in a way that does not do this?
Otherwise I can just make it reload the affected module again.

pydna/tests/test_module_dseqrecord.py

Lines 49 to 68 in 1099f0a

	def test_IPython_missing(monkeypatch):
	import IPython
	from pydna import dseqrecord
	# assert dseqrecord._display is IPython.display.display
	assert dseqrecord._display_html == IPython.display.display_html
	import sys
	import copy
	fakesysmodules = copy.copy(sys.modules)
	fakesysmodules["IPython.display"] = None
	monkeypatch.delitem(sys.modules, "IPython.display")
	monkeypatch.setattr("sys.modules", fakesysmodules)
	from importlib import reload
	reload(dseqrecord)
	from pydna import dseqrecord
	assert dseqrecord._display_html("item") == "item"
	# assert dseqrecord._HTML("item") == "item"

[BjornFJohansson]

Hi, this I did long ago to test this in Dseqrecord:

try:
    from IPython.display import display_html as _display_html
except ImportError:

    def _display_html(item, raw=None):
        return item

basically, if IPython.display is not available, possibly because IPython is installed (not in sys.modules)
There is an alternative _display_html function that does not do anything.

Possibly there is a way to do this without reload.