Skip to content

Commit 16de7db

Browse files
committed
Simplify er_blade
This function did two things unnecessarily: * Convert blade reps to base rep before calling mul. This is already handled within `mul`, so there's no need to do it again at the call site. * Branch depending on the mode string - this branching is already handled by `Mul`
1 parent d4fe3db commit 16de7db

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

galgebra/ga.py

+3-15
Original file line numberDiff line numberDiff line change
@@ -1650,22 +1650,10 @@ def er_blade(self, er, blade, mode='*', left=True):
16501650
16511651
.. math:: e^{j}*(e_{i_{1}}\wedge ...\wedge e_{i_{r}})
16521652
"""
1653-
if mode == '*':
1654-
base = self.blade_to_base_rep(blade)
1655-
if left:
1656-
return self.base_to_blade_rep(self.mul(er, base))
1657-
else:
1658-
return self.base_to_blade_rep(self.mul(base, er))
1659-
elif mode == '^':
1660-
if left:
1661-
return self.wedge(er, blade)
1662-
else:
1663-
return self.wedge(blade, er)
1653+
if left:
1654+
return self.Mul(er, blade, mode=mode)
16641655
else:
1665-
if left:
1666-
return self.Mul(er, blade, mode=mode)
1667-
else:
1668-
return self.Mul(blade, er, mode=mode)
1656+
return self.Mul(blade, er, mode=mode)
16691657

16701658
def blade_derivation(self, blade, ib):
16711659
"""

0 commit comments

Comments
 (0)