Skip to content

Commit 5937f3d

Browse files
[refactor] Clean up unnecessary variables in test_builder
1 parent b8ad876 commit 5937f3d

File tree

1 file changed

+13
-23
lines changed

1 file changed

+13
-23
lines changed

tests/test_builder.py

+13-23
Original file line numberDiff line numberDiff line change
@@ -802,14 +802,8 @@ def test_class_base_props(self) -> None:
802802
def test_class_locals(self) -> None:
803803
"""Test the 'locals' dictionary of an astroid class."""
804804
module = self.module
805-
klass1 = module["YO"]
806-
locals1 = klass1.locals
807-
keys = sorted(locals1.keys())
808805
assert_keys = ["__annotations__", "__init__", "__module__", "__qualname__", "a"]
809-
self.assertEqual(keys, assert_keys)
810-
klass2 = module["YOUPI"]
811-
locals2 = klass2.locals
812-
keys = locals2.keys()
806+
self.assertEqual(sorted(module["YO"].locals.keys()), assert_keys)
813807
assert_keys = [
814808
"__annotations__",
815809
"__init__",
@@ -820,39 +814,35 @@ def test_class_locals(self) -> None:
820814
"method",
821815
"static_method",
822816
]
823-
self.assertEqual(sorted(keys), assert_keys)
817+
self.assertEqual(sorted(module["YOUPI"].locals.keys()), assert_keys)
824818

825819
def test_class_instance_attrs(self) -> None:
826820
module = self.module
827-
klass1 = module["YO"]
828-
klass2 = module["YOUPI"]
829-
self.assertEqual(list(klass1.instance_attrs.keys()), ["yo"])
830-
self.assertEqual(list(klass2.instance_attrs.keys()), ["member"])
821+
self.assertEqual(list(module["YO"].instance_attrs.keys()), ["yo"])
822+
self.assertEqual(list(module["YOUPI"].instance_attrs.keys()), ["member"])
831823

832824
def test_class_basenames(self) -> None:
833825
module = self.module
834-
klass1 = module["YO"]
835-
klass2 = module["YOUPI"]
836-
self.assertEqual(klass1.basenames, [])
837-
self.assertEqual(klass2.basenames, ["YO"])
826+
self.assertEqual(module["YO"].basenames, [])
827+
self.assertEqual(module["YOUPI"].basenames, ["YO"])
838828

839829
def test_method_base_props(self) -> None:
840830
"""Test base properties and method of an astroid method."""
841-
klass2 = self.module["YOUPI"]
842-
# "normal" method
843-
method = klass2["method"]
831+
method = self.module["YOUPI"]["method"]
844832
self.assertEqual(method.name, "method")
845833
self.assertEqual([n.name for n in method.args.args], ["self"])
846834
assert isinstance(method.doc_node, nodes.Const)
847835
self.assertEqual(method.doc_node.value, "method\n test")
848836
self.assertEqual(method.fromlineno, 48)
849837
self.assertEqual(method.type, "method")
850-
# class method
851-
method = klass2["class_method"]
838+
839+
def test_class_method_base_props(self) -> None:
840+
method = self.module["YOUPI"]["class_method"]
852841
self.assertEqual([n.name for n in method.args.args], ["cls"])
853842
self.assertEqual(method.type, "classmethod")
854-
# static method
855-
method = klass2["static_method"]
843+
844+
def test_static_method_base_props(self) -> None:
845+
method = self.module["YOUPI"]["static_method"]
856846
self.assertEqual(method.args.args, [])
857847
self.assertEqual(method.type, "staticmethod")
858848

0 commit comments

Comments
 (0)