Skip to content

Commit e938c17

Browse files
Pierre-SassoulasPierre-Sassoulas
committed
[logging-too-many-args] Add a regression test for float formatting
Refs #9118
1 parent 4203d87 commit e938c17

8 files changed

+64
-13
lines changed

‎tests/functional/l/logging/logging_too_many_args.py

-8
This file was deleted.

‎tests/functional/l/logging/logging_too_many_args.txt

-5
This file was deleted.

‎tests/functional/l/logging/logging_too_many_args_new_style.py

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
"""Tests for logging-too-many-args with logging-format-style=new
2+
for both new style and old style."""
3+
import logging
4+
5+
logging.error("constant string", 1, 2) # [logging-too-many-args]
6+
logging.error("{}", 1, 2) # [logging-too-many-args]
7+
logging.error("{0}", 1, 2) # [logging-too-many-args]
8+
logging.error("{}, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
9+
logging.error("{0}, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
10+
# Regression test for https://github.com/pylint-dev/pylint/issues/9118
11+
logging.warning( "The frequency is: {:.2f} MHz", 2.3 )
12+
13+
logging.error("constant string", 1, 2) # [logging-too-many-args]
14+
logging.error("%s", 1, 2) # [logging-too-many-args]
15+
logging.error("%s", 1, 2) # [logging-too-many-args]
16+
logging.error("%s, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
17+
logging.error("%s, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
18+
# Regression test for https://github.com/pylint-dev/pylint/issues/9118
19+
# This is a false positive currently
20+
logging.warning( "The frequency is: %f MHz", 2.3 ) # [logging-too-many-args]

‎tests/functional/l/logging/logging_too_many_args.rc renamed to ‎tests/functional/l/logging/logging_too_many_args_new_style.rc

File renamed without changes.

‎tests/functional/l/logging/logging_too_many_args_new_style.txt

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:UNDEFINED
2+
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:UNDEFINED
3+
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:UNDEFINED
4+
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:UNDEFINED
5+
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:UNDEFINED
6+
logging-too-many-args:13:0:13:38::Too many arguments for logging format string:UNDEFINED
7+
logging-too-many-args:14:0:14:25::Too many arguments for logging format string:UNDEFINED
8+
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:UNDEFINED
9+
logging-too-many-args:16:0:16:48::Too many arguments for logging format string:UNDEFINED
10+
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:UNDEFINED
11+
logging-too-many-args:20:0:20:50::Too many arguments for logging format string:UNDEFINED

‎tests/functional/l/logging/logging_too_many_args_old_style.py

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
"""Tests for logging-too-many-args using logging-format-style=old
2+
for both new style and old style."""
3+
import logging
4+
5+
logging.error("constant string", 1, 2) # [logging-too-many-args]
6+
logging.error("{}", 1, 2) # [logging-too-many-args]
7+
logging.error("{0}", 1, 2) # [logging-too-many-args]
8+
logging.error("{}, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
9+
logging.error("{0}, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
10+
# Regression test for https://github.com/pylint-dev/pylint/issues/9118
11+
# This is a false positive currently
12+
logging.warning( "The frequency is: {:.2f} MHz", 2.3 ) # [logging-too-many-args]
13+
14+
logging.error("constant string", 1, 2) # [logging-too-many-args]
15+
logging.error("%s", 1, 2) # [logging-too-many-args]
16+
logging.error("%s", 1, 2) # [logging-too-many-args]
17+
logging.error("%s, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
18+
logging.error("%s, {named}", 1, 2, {"named": 1}) # [logging-too-many-args]
19+
# Regression test for https://github.com/pylint-dev/pylint/issues/9118
20+
logging.warning( "The frequency is: %f MHz", 2.3 )

‎tests/functional/l/logging/logging_too_many_args_old_style.rc

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[LOGGING]
2+
logging-format-style=old

‎tests/functional/l/logging/logging_too_many_args_old_style.txt

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
logging-too-many-args:5:0:5:38::Too many arguments for logging format string:UNDEFINED
2+
logging-too-many-args:6:0:6:25::Too many arguments for logging format string:UNDEFINED
3+
logging-too-many-args:7:0:7:26::Too many arguments for logging format string:UNDEFINED
4+
logging-too-many-args:8:0:8:48::Too many arguments for logging format string:UNDEFINED
5+
logging-too-many-args:9:0:9:49::Too many arguments for logging format string:UNDEFINED
6+
logging-too-many-args:12:0:12:54::Too many arguments for logging format string:UNDEFINED
7+
logging-too-many-args:14:0:14:38::Too many arguments for logging format string:UNDEFINED
8+
logging-too-many-args:15:0:15:25::Too many arguments for logging format string:UNDEFINED
9+
logging-too-many-args:16:0:16:25::Too many arguments for logging format string:UNDEFINED
10+
logging-too-many-args:17:0:17:48::Too many arguments for logging format string:UNDEFINED
11+
logging-too-many-args:18:0:18:48::Too many arguments for logging format string:UNDEFINED

0 commit comments

Comments
 (0)