fix pipe buffoonery

LordIdra · LordIdra · commit fe303342ce51 · 2025-09-18T04:16:53.000+01:00
diff --git a/pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/fluid/connecting/ConnectingService.kt b/pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/fluid/connecting/ConnectingService.kt
@@ -21,7 +21,8 @@ object ConnectingService : org.bukkit.event.Listener {
 
     fun startConnection(player: Player, startPoint: ConnectingPoint, pipe: FluidPipe) {
         check(!ConnectingService.connectionsInProgress.containsKey(player))
-        ConnectingService.connectionsInProgress.put(player, ConnectingTask(player, startPoint, pipe))
+        // Clone to prevent the PylonItem instance being shared between player's hotbar and the pipe itself
+        ConnectingService.connectionsInProgress.put(player, ConnectingTask(player, startPoint, FluidPipe(pipe.stack.clone())))
     }
 
     @JvmStatic

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@ object ConnectingService : org.bukkit.event.Listener {`
`21`	`21`
`22`	`22`	`fun startConnection(player: Player, startPoint: ConnectingPoint, pipe: FluidPipe) {`
`23`	`23`	`check(!ConnectingService.connectionsInProgress.containsKey(player))`
`24`		`- ConnectingService.connectionsInProgress.put(player, ConnectingTask(player, startPoint, pipe))`
	`24`	`+ // Clone to prevent the PylonItem instance being shared between player's hotbar and the pipe itself`
	`25`	`+ ConnectingService.connectionsInProgress.put(player, ConnectingTask(player, startPoint, FluidPipe(pipe.stack.clone())))`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`@JvmStatic`