Fix mypy type errors, failing tests, and add safety warnings

- Add ConfigEntry None checks in coordinator.py to satisfy mypy
- Add proper type annotations for select entities list in select.py
- Add dict[str, Any] annotation for attrs in extra_state_attributes
- Remove unused type:ignore comment from climate.py
- Update coordinator tests to pass config_entry parameter
- Update options flow test to expect experimental_features in result
- Add detailed safety warnings in strings.json about remote temperature risks

Author: ashleigh-hopkins

custom_components/mitsubishi/climate.py

@@ -123,7 +123,7 @@ class MitsubishiClimate(MitsubishiEntity, ClimateEntity):
         | ClimateEntityFeature.TARGET_TEMPERATURE
         | ClimateEntityFeature.FAN_MODE
         | ClimateEntityFeature.SWING_MODE
-        | ClimateEntityFeature.SWING_HORIZONTAL_MODE  # type: ignore[attr-defined]
+        | ClimateEntityFeature.SWING_HORIZONTAL_MODE
     )
 
     def __init__(

custom_components/mitsubishi/coordinator.py

@@ -53,12 +53,13 @@ def set_remote_temp_mode(self, enabled: bool) -> None:
         _LOGGER.info("Remote temperature mode set to: %s", enabled)
 
         # Persist to config entry options
-        new_options = dict(self.config_entry.options)
-        new_options[CONF_REMOTE_TEMP_MODE] = enabled
-        self.hass.config_entries.async_update_entry(
-            self.config_entry,
-            options=new_options,
-        )
+        if self.config_entry is not None:
+            new_options = dict(self.config_entry.options)
+            new_options[CONF_REMOTE_TEMP_MODE] = enabled
+            self.hass.config_entries.async_update_entry(
+                self.config_entry,
+                options=new_options,
+            )
 
     @property
     def remote_temp_mode(self) -> bool:
@@ -68,6 +69,8 @@ def remote_temp_mode(self) -> bool:
     @property
     def experimental_features_enabled(self) -> bool:
         """Return whether experimental features are enabled."""
+        if self.config_entry is None:
+            return False
         return self.config_entry.options.get(CONF_EXPERIMENTAL_FEATURES, False)
 
     async def get_unit_info(self) -> dict:
@@ -103,6 +106,8 @@ async def _async_update_data(self) -> ParsedDeviceState:
 
     async def _send_remote_temperature(self) -> None:
         """Send remote temperature to AC if configured and available."""
+        if self.config_entry is None:
+            return
         external_entity_id = self.config_entry.options.get(CONF_EXTERNAL_TEMP_ENTITY)
 
         if not external_entity_id:

custom_components/mitsubishi/select.py

@@ -30,7 +30,7 @@ async def async_setup_entry(
     """Set up Mitsubishi select entities."""
     coordinator = hass.data[DOMAIN][config_entry.entry_id]
 
-    entities = [MitsubishiPowerSavingSelect(coordinator, config_entry)]
+    entities: list[SelectEntity] = [MitsubishiPowerSavingSelect(coordinator, config_entry)]
 
     # Only add Temperature Source selector if experimental features are enabled
     if config_entry.options.get(CONF_EXPERIMENTAL_FEATURES, False):
@@ -153,7 +153,7 @@ async def async_select_option(self, option: str) -> None:
     @property
     def extra_state_attributes(self) -> dict[str, Any]:
         """Return entity specific state attributes."""
-        attrs = {"source": "Mitsubishi AC"}
+        attrs: dict[str, Any] = {"source": "Mitsubishi AC"}
         external_entity_id = self._config_entry.options.get(CONF_EXTERNAL_TEMP_ENTITY)
         if external_entity_id:
             attrs["external_temperature_entity"] = external_entity_id

custom_components/mitsubishi/strings.json

@@ -38,8 +38,8 @@
           "external_temperature_entity": "External Temperature Sensor"
         },
         "data_description": {
-          "experimental_features": "Enable experimental features like remote temperature sensor support. These features may change or be removed in future versions.",
-          "external_temperature_entity": "Select a temperature sensor to use as the room temperature when Remote mode is selected. Leave empty to only use the internal sensor."
+          "experimental_features": "Enable experimental features like remote temperature sensor support. These features may change or be removed in future versions. WARNING: The remote temperature feature should NOT be used for critical heating/cooling needs. If your Home Assistant server goes offline, your external sensor becomes unavailable, or provides invalid readings, the AC will NOT automatically revert to its internal sensor. You must manually switch back to Internal mode.",
+          "external_temperature_entity": "Select a temperature sensor to use as the room temperature when Remote mode is selected. Leave empty to only use the internal sensor. The AC must receive regular temperature updates - if updates stop, the AC continues using the last received value indefinitely."
         }
       }
     },

tests/test_config_flow.py

@@ -370,7 +370,8 @@ async def test_options_flow_successful_update(self, hass: HomeAssistant, mock_co
             result = await options_flow.async_step_init(new_data)
 
         assert result["type"] == FlowResultType.CREATE_ENTRY
-        assert result["data"] == {}
+        # Options flow now returns experimental_features setting
+        assert result["data"] == {"experimental_features": False}
         hass.config_entries.async_update_entry.assert_called_once_with(
             mock_config_entry, data=new_data
         )

tests/test_coordinator.py

@@ -11,10 +11,10 @@
 
 
 @pytest.mark.asyncio
-async def test_coordinator_init(hass, mock_mitsubishi_controller):
+async def test_coordinator_init(hass, mock_mitsubishi_controller, mock_config_entry):
     """Test coordinator initialization."""
     coordinator = MitsubishiDataUpdateCoordinator(
-        hass, mock_mitsubishi_controller, DEFAULT_SCAN_INTERVAL
+        hass, mock_mitsubishi_controller, mock_config_entry, DEFAULT_SCAN_INTERVAL
     )
 
     assert coordinator.controller == mock_mitsubishi_controller
@@ -24,18 +24,22 @@ async def test_coordinator_init(hass, mock_mitsubishi_controller):
 
 
 @pytest.mark.asyncio
-async def test_coordinator_init_custom_interval(hass, mock_mitsubishi_controller):
+async def test_coordinator_init_custom_interval(hass, mock_mitsubishi_controller, mock_config_entry):
     """Test coordinator initialization with custom scan interval."""
     custom_interval = 60
-    coordinator = MitsubishiDataUpdateCoordinator(hass, mock_mitsubishi_controller, custom_interval)
+    coordinator = MitsubishiDataUpdateCoordinator(
+        hass, mock_mitsubishi_controller, mock_config_entry, custom_interval
+    )
 
     assert coordinator.update_interval == timedelta(seconds=custom_interval)
 
 
 @pytest.mark.asyncio
-async def test_fetch_unit_info_success(hass, mock_mitsubishi_controller):
+async def test_fetch_unit_info_success(hass, mock_mitsubishi_controller, mock_config_entry):
     """Test successful unit info fetching."""
-    coordinator = MitsubishiDataUpdateCoordinator(hass, mock_mitsubishi_controller)
+    coordinator = MitsubishiDataUpdateCoordinator(
+        hass, mock_mitsubishi_controller, mock_config_entry
+    )
 
     # Mock unit info fetch
     expected_unit_info = {"Adapter Information": {"Adaptor name": "MAC-577IF-2E"}}
@@ -47,9 +51,11 @@ async def test_fetch_unit_info_success(hass, mock_mitsubishi_controller):
 
 
 @pytest.mark.asyncio
-async def test_async_update_data_success(hass, mock_mitsubishi_controller):
+async def test_async_update_data_success(hass, mock_mitsubishi_controller, mock_config_entry):
     """Test successful data update."""
-    coordinator = MitsubishiDataUpdateCoordinator(hass, mock_mitsubishi_controller)
+    coordinator = MitsubishiDataUpdateCoordinator(
+        hass, mock_mitsubishi_controller, mock_config_entry
+    )
 
     with patch.object(
         hass,
@@ -63,9 +69,11 @@ async def test_async_update_data_success(hass, mock_mitsubishi_controller):
 
 
 @pytest.mark.asyncio
-async def test_async_update_data_fetch_status_fails(hass, mock_mitsubishi_controller):
+async def test_async_update_data_fetch_status_fails(hass, mock_mitsubishi_controller, mock_config_entry):
     """Test data update when fetch_status fails."""
-    coordinator = MitsubishiDataUpdateCoordinator(hass, mock_mitsubishi_controller)
+    coordinator = MitsubishiDataUpdateCoordinator(
+        hass, mock_mitsubishi_controller, mock_config_entry
+    )
 
     mock_mitsubishi_controller.fetch_status.side_effect = UpdateFailed("foobar")