improve test scripts

`show_pdf_page` and `insert_image` are now tested with rotated insertions.

Author: JorjMcKie

tests/test_insertimage.py

@@ -1,5 +1,5 @@
 """
-* Insert same image in two places of a page.
+* Insert same image with different rotations in two places of a page.
 * Extract bboxes and transformation matrices via different methods
 * Assert equality of bboxes and transformations
 * Assert image locations are inside given rectangles
@@ -19,7 +19,7 @@ def test_insert():
     r1 = fitz.Rect(50, 50, 100, 100)
     r2 = fitz.Rect(50, 150, 200, 400)
     page.insert_image(r1, filename=imgfile)
-    page.insert_image(r2, filename=imgfile)
+    page.insert_image(r2, filename=imgfile, rotate=270)
     imglist = page.get_images(True)
     assert len(imglist) == 2
     bbox1, transform1 = page.get_image_bbox(imglist[0], transform=True)

tests/test_showpdfpage.py

@@ -1,9 +1,9 @@
 """
 Tests:
     * Convert some image to a PDF
-    * Insert it in given rectangle of a PDF page
+    * Insert it rotated in some rectangle of a PDF page
     * Assert PDF Form XObject has been created
-    * Assert inserted PDF is inside given retangle
+    * Assert that image contained in inserted PDF is inside given retangle
 """
 import os
 
@@ -16,16 +16,16 @@
 def test_insert():
     doc = fitz.open()
     page = doc.new_page()
-    r1 = fitz.Rect(50, 50, 100, 100)  # insert in here
+    rect = fitz.Rect(50, 50, 100, 100)  # insert in here
     img = fitz.open(imgfile)  # open image
     tobytes = img.convert_to_pdf()  # get its PDF version (bytes object)
     src = fitz.open("pdf", tobytes)  # open as PDF
-    page.show_pdf_page(r1, src, 0)  # insert in rectangle
-    img = page.get_images(True)[0]  # make full image list of the page
-    assert img[-1] > 0  # xref of Form XObject!
+    xref = page.show_pdf_page(rect, src, 0, rotate=-23)  # insert in rectangle
+    # extract just inserted image info
+    img = page.get_images(True)[0]
+    assert img[-1] == xref  # xref of Form XObject!
     img = page.get_image_info()[0]  # read the page's images
 
-    # Multiple computations may lead to rounding issues, so we need
-    # some generosity here:
-    bbox = list(map(round, img["bbox"]))
-    assert bbox in r1
+    # Multiple computations may have lead to rounding deviations, so we need
+    # some generosity here: enlarge rect by 1 point in each direction.
+    assert img["bbox"] in rect + (-1, -1, 1, 1)