Prevent double encoding of binary #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me so far. Regarding the backwards-compatibility question, how about we roll the double base64 encoding/decoding into the existing Binary attributes, deprecate them, and create a new set of binary attributes (e.g. |
|
can we update this and merge? |
|
also add a test? 😸 |
|
Superseded by #1112 (oh wow, a lot of numbers gone by...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Unfortunately, all Binary data is double-encoded that has been written by Pynamo. This PR prevents that from happening going forward, but we need to have a way to deserialize the double-encoded data so that we don't break everyone going forward.
TODO: