Delete should not validate non-key attributes in transaction

[wobeng]

Referring to #216 for transaction

[ikonst]

@hallie do we need to fix this for transactions?

[hallie]

@ikonst @wobeng we would need to change this line to:

args, save_kwargs = self._get_save_args(null_check=not (is_update or is_delete))

[wobeng]

Hi guys,

can we add this to the next release?

[wobeng]

@hallie when I made a change locally, I got this error below

    
        operation_kwargs[TABLE_NAME] = table_name
        operation_kwargs.update(self.get_identifier_map(table_name, hash_key, range_key, key=key))
        if attributes:
            attrs = self.get_item_attribute_map(table_name, attributes)
>           operation_kwargs[ITEM].update(attrs[ITEM])
E           KeyError: 'Item'

../../env36/lib64/python3.6/site-packages/pynamodb/connection/base.py:854: KeyError

[wobeng]

I had to do monkey patch

def get_operation_kwargs_from_instance(self,
                                       key=KEY,
                                       actions=None,
                                       condition=None,
                                       return_values_on_condition_failure=None):
    is_update = actions is not None
    is_delete = actions is None and key is KEY
    null_check = not (is_update or is_delete)
    args, save_kwargs = self._get_save_args(attributes=(not is_delete), null_check=null_check)
    kwargs = dict(
        key=key,
        actions=actions,
        condition=condition,
        return_values_on_condition_failure=return_values_on_condition_failure
    )
    if not is_update:
        kwargs.update(save_kwargs)
    elif pythonic(RANGE_KEY) in save_kwargs:
        kwargs[pythonic(RANGE_KEY)] = save_kwargs[pythonic(RANGE_KEY)]
    return self._get_connection().get_operation_kwargs(*args, **kwargs)


Model.get_operation_kwargs_from_instance = get_operation_kwargs_from_instance

[hallie]

@wobeng sorry for the late response--did the second comment mean that you got it to work?

[wobeng]

@hallie #677 (comment) worked!

[wobeng]

any update on this fix? @jlafon @garrettheel

[wobeng]

can this be added to the next update?

[garrettheel]

@wobeng would you be able to submit a PR with the change that worked for you? That's the quickest way to get this in as a fix

[wobeng]

@garrettheel I will submit a pr