Skip to content

Commit 0c0f820

Browse files
committed
Localize the name of the Download directory, use it on Home screen
1 parent a663885 commit 0c0f820

File tree

6 files changed

+14
-16
lines changed

6 files changed

+14
-16
lines changed

app/src/main/java/org/fairscan/app/MainViewModel.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,8 +319,7 @@ class MainViewModel(
319319

320320
fun saveFile(pdfFile: File): File {
321321
val copiedFile = pdfFileManager.copyToExternalDir(pdfFile)
322-
val dirName = copiedFile.parentFile?.name
323-
_pdfUiState.update { it.copy(savedFileUri = pdfFile.toUri(), saveDirectoryName = dirName) }
322+
_pdfUiState.update { it.copy(savedFileUri = pdfFile.toUri()) }
324323
return copiedFile
325324
}
326325

app/src/main/java/org/fairscan/app/ui/UiState.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ data class PdfGenerationUiState(
2323
val generatedPdf: GeneratedPdf? = null,
2424
val desiredFilename: String = "",
2525
val savedFileUri: Uri? = null,
26-
val saveDirectoryName: String? = null,
2726
val hasSharedPdf: Boolean = false,
2827
val errorMessage: String? = null,
2928
) {

app/src/main/java/org/fairscan/app/view/ExportScreen.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ private fun TextFieldAndPdfInfos(
215215
}
216216
}
217217

218-
if (uiState.saveDirectoryName != null) {
219-
SavePdfBar(onOpen, uiState.saveDirectoryName)
218+
if (uiState.savedFileUri != null) {
219+
SavedPdfBar(onOpen)
220220
}
221221
if (uiState.errorMessage != null) {
222222
ErrorBar(uiState.errorMessage)
@@ -330,7 +330,7 @@ fun ExportButton(
330330
}
331331

332332
@Composable
333-
private fun SavePdfBar(onOpen: () -> Unit, saveDirectoryName: String) {
333+
private fun SavedPdfBar(onOpen: () -> Unit) {
334334
Row(
335335
verticalAlignment = Alignment.CenterVertically,
336336
horizontalArrangement = Arrangement.Absolute.SpaceBetween,
@@ -340,9 +340,11 @@ private fun SavePdfBar(onOpen: () -> Unit, saveDirectoryName: String) {
340340
.padding(vertical = 8.dp, horizontal = 16.dp),
341341
) {
342342
Text(
343-
text = stringResource(R.string.pdf_saved_to, saveDirectoryName),
344-
style = MaterialTheme.typography.bodyMedium
343+
text = stringResource(R.string.pdf_saved_to),
344+
style = MaterialTheme.typography.bodyMedium,
345+
modifier = Modifier.weight(1f),
345346
)
347+
Spacer(Modifier.width(8.dp))
346348
MainActionButton(
347349
onClick = onOpen,
348350
text = stringResource(R.string.open),
@@ -401,7 +403,6 @@ fun PreviewExportScreenAfterSave() {
401403
uiState = PdfGenerationUiState(
402404
generatedPdf = GeneratedPdf(file, 442897L, 3),
403405
savedFileUri = file.toUri(),
404-
saveDirectoryName = "Downloads",
405406
),
406407
)
407408
}
@@ -422,7 +423,6 @@ fun PreviewExportScreenAfterSaveHorizontal() {
422423
uiState = PdfGenerationUiState(
423424
generatedPdf = GeneratedPdf(file, 442897L, 3),
424425
savedFileUri = file.toUri(),
425-
saveDirectoryName = "Downloads",
426426
),
427427
)
428428
}

app/src/main/res/values-de/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<string name="filename">Dateiname</string>
2121
<string name="file_size">Dateigröße: %1$s</string>
2222
<string name="grant_permission">Berechtigung erteilen</string>
23-
<string name="last_saved_pdf_files">Zuletzt gespeicherte PDF-Dateien:</string>
23+
<string name="last_saved_pdf_files">Zuletzt gespeicherte PDF-Dateien in Downloads:</string>
2424
<string name="libraries">Bibliotheken</string>
2525
<string name="libraries_intro">Diese Anwendung verwendet mehrere Open-Source-Bibliotheken, darunter:</string>
2626
<string name="libraries_open_source">Open-Source-Bibliotheken</string>
@@ -29,7 +29,7 @@
2929
<string name="new_document_warning">Das aktuelle Dokument geht verloren. Möchten Sie fortfahren?</string>
3030
<string name="open">Öffnen</string>
3131
<string name="open_pdf">PDF öffnen</string>
32-
<string name="pdf_saved_to">PDF gespeichert unter %1$s</string>
32+
<string name="pdf_saved_to">PDF gespeichert in Downloads</string>
3333
<string name="resume">Fortsetzen</string>
3434
<string name="save">Speichern</string>
3535
<string name="scan_button">Neuer Scan</string>

app/src/main/res/values-fr/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<string name="filename">Nom de fichier</string>
2121
<string name="file_size">Taille du fichier : %1$s</string>
2222
<string name="grant_permission">Autoriser</string>
23-
<string name="last_saved_pdf_files">Derniers fichiers PDF enregistrés :</string>
23+
<string name="last_saved_pdf_files">Derniers fichiers PDF enregistrés dans Téléchargements :</string>
2424
<string name="libraries">Bibliothèques</string>
2525
<string name="libraries_intro">Cette application utilise plusieurs bibliothèques open source, notamment :</string>
2626
<string name="libraries_open_source">Bibliothèques open source</string>
@@ -29,7 +29,7 @@
2929
<string name="new_document_warning">Le scan en cours sera perdu. Voulez-vous continuer ?</string>
3030
<string name="open">Ouvrir</string>
3131
<string name="open_pdf">Ouvrir le PDF</string>
32-
<string name="pdf_saved_to">PDF enregistré dans %1$s</string>
32+
<string name="pdf_saved_to">PDF enregistré dans Téléchargements</string>
3333
<string name="resume">Reprendre</string>
3434
<string name="save">Enregistrer</string>
3535
<string name="scan_button">Nouveau scan</string>

app/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<string name="filename">Filename</string>
2222
<string name="file_size">File size: %1$s</string>
2323
<string name="grant_permission">Grant permission</string>
24-
<string name="last_saved_pdf_files">Last saved PDF files:</string>
24+
<string name="last_saved_pdf_files">Last PDF files saved in Downloads:</string>
2525
<string name="libraries">Libraries</string>
2626
<string name="libraries_intro">This application uses several open-source libraries, including:</string>
2727
<string name="libraries_open_source">Open-source libraries</string>
@@ -30,7 +30,7 @@
3030
<string name="new_document_warning">The current scan will be lost. Do you want to continue?</string>
3131
<string name="open">Open</string>
3232
<string name="open_pdf">Open PDF</string>
33-
<string name="pdf_saved_to">PDF saved to %1$s</string>
33+
<string name="pdf_saved_to">PDF saved in Downloads</string>
3434
<string name="resume">Resume</string>
3535
<string name="save">Save</string>
3636
<string name="scan_button">New Scan</string>

0 commit comments

Comments
 (0)