Improvement: just set rpath on repair everytime

[fzakaria]

Please let me know if you all appreciate these code improvements as I scan the code.

I am reading the code for repair.py and I believe it would be simpler to always just squash the RUNPATH/RPATH [1]

I see a few other improvements that can be made. Happy to upstream some if you find them useful.

[1]

auditwheel/src/auditwheel/repair.py

Line 165 in 3636dad

patcher.set_rpath(dest_path, dest_dir)

[auvipy]

can you share some context and example test case please?

[fzakaria]

There isn't a testcase per-say -- this is a code simplification suggestion.
The code I linked sets the RPATH only if it is already set on the binary and does a series of control-flow logic.

My suggestion/idea: why not just stamp the RPATH every time regardless? It is safe to have the RPATH point to the destination directory every time.