Merge pull request #13788 from notatallshaw/match-release-control-behavior-to-format-control-behavior-with-cli-and-requirements-file

Match release control behavior to the same as format control behavior

Author: notatallshaw

news/13788.bugfix.rst

@@ -0,0 +1,2 @@
+Fix ``--pre`` not being respected when a requirement file
+includes an option e.g. ``-extra-index-url``.

src/pip/_internal/req/req_file.py

@@ -283,7 +283,9 @@ def handle_option_line(
             opts.release_control.all_releases.add(":all:")
 
         if opts.release_control:
-            finder.set_release_control(opts.release_control)
+            if not finder.release_control:
+                # First time seeing release_control, set it on finder
+                finder.set_release_control(opts.release_control)
 
         if opts.prefer_binary:
             finder.set_prefer_binary()
@@ -440,6 +442,7 @@ def parse_line(line: str) -> tuple[str, Values]:
         defaults.index_url = None
         if finder:
             defaults.format_control = finder.format_control
+            defaults.release_control = finder.release_control
 
         args_str, options_str = break_args_options(line)
 

tests/functional/test_install_format_control.py

@@ -0,0 +1,113 @@
+"""Tests for --only-binary and --no-binary format control flags.
+
+These tests verify edge case CLI and requirements file interaction behavior,
+matching the pattern established by --all-releases and --only-final tests.
+"""
+
+from __future__ import annotations
+
+from tests.lib import (
+    PipTestEnvironment,
+    create_basic_sdist_for_package,
+    create_basic_wheel_for_package,
+)
+
+
+def test_order_no_binary_then_only_binary(script: PipTestEnvironment) -> None:
+    """Test --no-binary=:all: --only-binary=<package>.
+
+    When the user specifies --no-binary=:all: --only-binary=simple, they
+    expect 'simple' to allow wheels (later flag overrides).
+    """
+    wheel_path = create_basic_wheel_for_package(script, "simple", "1.0")
+
+    # This should allow wheels for 'simple' because --only-binary comes after
+    result = script.pip_install_local(
+        "--no-binary=:all:",
+        "--only-binary=simple",
+        "simple==1.0",
+        find_links=[wheel_path.parent],
+    )
+    script.assert_installed(simple="1.0")
+    # Should NOT be building from source
+    assert "Building wheel for simple" not in result.stdout
+
+
+def test_order_only_binary_then_no_binary(script: PipTestEnvironment) -> None:
+    """Test --only-binary=:all: --no-binary=<package>.
+
+    When the user specifies --only-binary=:all: --no-binary=simple,
+    'simple' should be built from source (later flag overrides).
+    """
+    wheel_path = create_basic_wheel_for_package(script, "simple", "1.0")
+    create_basic_sdist_for_package(script, "simple", "1.0")
+
+    # This should build from source for 'simple' because --no-binary comes after
+    result = script.pip_install_local(
+        "--only-binary=:all:",
+        "--no-binary=simple",
+        "simple==1.0",
+        find_links=[wheel_path.parent],
+    )
+    script.assert_installed(simple="1.0")
+    assert "Building wheel for simple" in result.stdout
+
+
+def test_reqfile_no_binary_overrides_cmdline_only_binary(
+    script: PipTestEnvironment,
+) -> None:
+    """Test requirements file --no-binary overrides command line --only-binary."""
+    wheel_path = create_basic_wheel_for_package(script, "simple", "1.0")
+    create_basic_sdist_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {wheel_path.parent.as_posix()}\n"
+        "--no-binary :all:\nsimple==1.0\n",
+    )
+
+    result = script.pip_install_local(
+        "--only-binary=:all:", "-r", req_file, find_links=[]
+    )
+    script.assert_installed(simple="1.0")
+    # Requirements file --no-binary should override CLI --only-binary
+    assert "Building wheel for simple" in result.stdout
+
+
+def test_reqfile_only_binary_overrides_cmdline_no_binary(
+    script: PipTestEnvironment,
+) -> None:
+    """Test requirements file --only-binary overrides command line --no-binary."""
+    # Create only a wheel, no sdist
+    wheel_path = create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {wheel_path.parent.as_posix()}\n"
+        "--only-binary :all:\nsimple==1.0\n",
+    )
+
+    result = script.pip_install_local(
+        "--no-binary=:all:", "-r", req_file, find_links=[]
+    )
+    result.assert_installed("simple", editable=False)
+    # Requirements file --only-binary should override CLI --no-binary
+    assert "Building wheel for simple" not in result.stdout
+
+
+def test_package_specific_overrides_all_in_requirements_file(
+    script: PipTestEnvironment,
+) -> None:
+    """Test package-specific setting overrides :all: in requirements file."""
+    wheel_path = create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {wheel_path.parent.as_posix()}\n--no-binary :all:\n"
+        "--only-binary simple\nsimple==1.0\n",
+    )
+
+    result = script.pip_install_local("-r", req_file, find_links=[])
+    result.assert_installed("simple", editable=False)
+    # Package-specific --only-binary should override --no-binary :all:
+    assert "Building wheel for simple" not in result.stdout

tests/functional/test_install_release_control.py

@@ -228,3 +228,83 @@ def test_no_matching_version_with_all_releases(
         expect_error=True,
     )
     assert "Could not find a version that satisfies the requirement" in result.stderr
+
+
+def test_pre_flag_with_requirements_file_containing_options(
+    script: PipTestEnvironment,
+) -> None:
+    """Test --pre on command line works with requirements file options.
+
+    Requirements file options overwrote command-line release control.
+    """
+    pre_pkg = create_basic_wheel_for_package(script, "simple", "2.0a1")
+    create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {pre_pkg.parent.as_posix()}\nsimple\n",
+    )
+
+    report = script.pip_install_local_report("-r", req_file, find_links=[])
+    assert len(report["install"]) == 1
+    assert report["install"][0]["metadata"]["version"] == "1.0"
+
+    report = script.pip_install_local_report("--pre", "-r", req_file, find_links=[])
+    assert len(report["install"]) == 1
+    assert report["install"][0]["metadata"]["version"] == "2.0a1"
+
+
+def test_reqfile_all_releases_overrides_cmdline_only_final(
+    script: PipTestEnvironment,
+) -> None:
+    """Test requirements file --all-releases overrides command line --only-final."""
+    pre_pkg = create_basic_wheel_for_package(script, "simple", "2.0a1")
+    create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {pre_pkg.parent.as_posix()}\n--all-releases :all:\nsimple\n",
+    )
+
+    report = script.pip_install_local_report(
+        "--only-final=:all:", "-r", req_file, find_links=[]
+    )
+    assert len(report["install"]) == 1
+    assert report["install"][0]["metadata"]["version"] == "2.0a1"
+
+
+def test_reqfile_only_final_overrides_cmdline_all_releases(
+    script: PipTestEnvironment,
+) -> None:
+    """Test requirements file --only-final overrides command line --all-releases."""
+    pre_pkg = create_basic_wheel_for_package(script, "simple", "2.0a1")
+    create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {pre_pkg.parent.as_posix()}\n--only-final :all:\nsimple\n",
+    )
+
+    report = script.pip_install_local_report(
+        "--all-releases=:all:", "-r", req_file, find_links=[]
+    )
+    assert len(report["install"]) == 1
+    assert report["install"][0]["metadata"]["version"] == "1.0"
+
+
+def test_package_specific_overrides_all_in_requirements_file(
+    script: PipTestEnvironment,
+) -> None:
+    """Test package-specific setting overrides :all: in requirements file."""
+    pre_pkg = create_basic_wheel_for_package(script, "simple", "2.0a1")
+    create_basic_wheel_for_package(script, "simple", "1.0")
+
+    req_file = script.temporary_file(
+        "requirements.txt",
+        f"--find-links {pre_pkg.parent.as_posix()}\n--all-releases :all:\n"
+        "--only-final simple\nsimple\n",
+    )
+
+    report = script.pip_install_local_report("-r", req_file, find_links=[])
+    assert len(report["install"]) == 1
+    assert report["install"][0]["metadata"]["version"] == "1.0"

tests/lib/__init__.py

@@ -736,6 +736,27 @@ def pip_install_local(
             cmd.insert(1, "--no-build-isolation")
         return self.pip(*cmd, **kwargs)
 
+    def pip_install_local_report(
+        self,
+        *args: StrPath,
+        find_links: StrPath | list[StrPath] = pathlib.Path(DATA_DIR, "packages"),
+        **kwargs: Any,
+    ) -> dict[str, Any]:
+        """
+        Invoke pip install with --dry-run --report and return parsed JSON report.
+        Includes --no-index and --find-links like pip_install_local.
+        """
+        result = self.pip_install_local(
+            "--dry-run",
+            "--report",
+            "-",
+            "--quiet",
+            *args,
+            find_links=find_links,
+            **kwargs,
+        )
+        return json.loads(result.stdout)
+
     def easy_install(self, *args: str, **kwargs: Any) -> TestPipResult:
         args = ("-m", "easy_install") + args
         return self.run("python", *args, **kwargs)