Fix inject --force reinstall behavior (#1833)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: marko1olo

changelog.d/1545.bugfix.md

@@ -0,0 +1,2 @@
+Ensure `pipx inject --force` reinstalls injected packages without persisting the force-reinstall option in package
+metadata.

src/pipx/commands/inject.py

@@ -97,6 +97,7 @@ def inject_dep(
         package_name=package_name,
         package_or_url=package_spec,
         pip_args=pip_args,
+        install_only_pip_args=["--force-reinstall"] if force else None,
         include_dependencies=include_dependencies,
         include_apps=include_apps,
         is_main_package=False,

src/pipx/venv.py

@@ -324,20 +324,22 @@ def install_package(
         include_apps: bool,
         is_main_package: bool,
         suffix: str = "",
+        install_only_pip_args: list[str] | None = None,
     ) -> None:
         # package_name in package specifier can mismatch URL due to user error
         package_or_url = fix_package_name(package_or_url, package_name)
 
         # check syntax and clean up spec and pip_args
         (package_or_url, pip_args) = parse_specifier_for_install(package_or_url, pip_args)
+        install_pip_args = [*(install_only_pip_args or []), *pip_args]
 
         _LOGGER.info("Installing %s", package_descr := full_package_description(package_name, package_or_url))
         with animate(f"installing {package_descr}", self.do_animation):
             process = self.backend.install(
                 venv_root=self.root,
                 venv_python=self.python_path,
                 requirements=[package_or_url],
-                pip_args=pip_args,
+                pip_args=install_pip_args,
                 verbose=self.verbose,
             )
         if process.returncode:

tests/test_inject.py

@@ -6,6 +6,8 @@
 
 from helpers import PIPX_METADATA_LEGACY_VERSIONS, mock_legacy_venv, run_pipx_cli, skip_if_windows
 from package_info import PKG
+from pipx import paths
+from pipx.pipx_metadata_file import PipxMetadata
 
 
 # Note that this also checks that packages used in other tests can be injected individually
@@ -113,3 +115,25 @@ def test_inject_with_req_file(pipx_temp_env, capsys, caplog, tmp_path, with_pack
     captured = capsys.readouterr()
     injected = re.findall(r"injected package (.+?) into venv pycowsay", captured.out)
     assert set(injected) == {pkg for pkg, _ in packages}
+
+
+def test_force_inject_reinstalls_without_storing_force(pipx_temp_env, caplog):
+    assert not run_pipx_cli(["install", "pycowsay"])
+    assert not run_pipx_cli(["inject", "pycowsay", PKG["black"]["spec"], "--pip-args=--no-cache-dir"])
+
+    caplog.clear()
+    assert not run_pipx_cli(
+        [
+            "inject",
+            "pycowsay",
+            PKG["black"]["spec"],
+            "--force",
+            "--verbose",
+            "--pip-args=--no-cache-dir",
+        ]
+    )
+
+    assert "--force-reinstall" in caplog.text
+
+    metadata = PipxMetadata(paths.ctx.venvs / "pycowsay")
+    assert metadata.injected_packages["black"].pip_args == ["--no-cache-dir"]