pass pip_args and verbose flag when determining package name (#321)

Author: Chad Smith

README.md

@@ -21,7 +21,7 @@ See Contributing for how to update this file.
 <a href="https://travis-ci.org/pipxproject/pipx"><img src="https://travis-ci.org/pipxproject/pipx.svg?branch=master" /></a>
 
 <a href="https://pypi.python.org/pypi/pipx/">
-<img src="https://img.shields.io/badge/pypi-0.15.0.0-blue.svg" /></a>
+<img src="https://img.shields.io/badge/pypi-0.15.0.1-blue.svg" /></a>
 <a href="https://github.com/ambv/black"><img alt="Code style: black" src="https://img.shields.io/badge/code%20style-black-000000.svg"></a>
 </p>
 

docs/changelog.md

@@ -1,3 +1,7 @@
+0.15.0.1
+
+- [bugfix] pass pip arguments to pip when determining package name
+
 0.15.0.0
 
 Upgrade instructions: When upgrading to 0.15.0.0 or above from a pre-0.15.0.0 version, you must re-install all packages to take advantage of the new persistent pipx metadata files introduced in this release. These metadata files store pip specification values, injected packages, any custom pip arguments, and more in each main package's venv. You can do this by running `pipx reinstall-all` or `pipx uninstall-all`, then reinstalling manually.

docs/index.md

@@ -21,7 +21,7 @@ See Contributing for how to update this file.
 <a href="https://travis-ci.org/pipxproject/pipx"><img src="https://travis-ci.org/pipxproject/pipx.svg?branch=master" /></a>
 
 <a href="https://pypi.python.org/pypi/pipx/">
-<img src="https://img.shields.io/badge/pypi-0.15.0.0-blue.svg" /></a>
+<img src="https://img.shields.io/badge/pypi-0.15.0.1-blue.svg" /></a>
 <a href="https://github.com/ambv/black"><img alt="Code style: black" src="https://img.shields.io/badge/code%20style-black-000000.svg"></a>
 </p>
 

src/pipx/commands/commands.py

@@ -35,7 +35,9 @@ def install(
     #   zip file, or tar.gz file.
     # Determine package_name to properly name venv directory.
     if venv_dir is None or package_name is None:
-        package_name = _package_name_from_spec(package_spec, python)
+        package_name = _package_name_from_spec(
+            package_spec, python, pip_args=pip_args, verbose=verbose
+        )
         venv_container = VenvContainer(constants.PIPX_LOCAL_VENVS)
         venv_dir = venv_container.get_venv_dir(package_name)
 
@@ -80,21 +82,23 @@ def install(
         raise
 
 
-def _package_name_from_spec(package_spec: str, python: str) -> str:
+def _package_name_from_spec(
+    package_spec: str, python: str, *, pip_args: List[str], verbose: bool
+) -> str:
     start_time = time.time()
 
-    # shortcut if valid PYPI name and not a local path
+    # shortcut if valid PyPI name and not a local path
     if valid_pypi_name(package_spec) and not Path(package_spec).exists():
         package_name = package_spec
         logging.info(f"Determined package name: {package_name}")
         logging.info(f"Package name determined in {time.time()-start_time:.1f}s")
         return package_name
 
     with tempfile.TemporaryDirectory() as temp_venv_dir:
-        venv = Venv(Path(temp_venv_dir), python=python)
+        venv = Venv(Path(temp_venv_dir), python=python, verbose=verbose)
         venv.create_venv(venv_args=[], pip_args=[])
         package_name = venv.install_package_no_deps(
-            package_or_url=package_spec, pip_args=[]
+            package_or_url=package_spec, pip_args=pip_args
         )
 
     logging.info(f"Package name determined in {time.time()-start_time:.1f}s")
@@ -205,7 +209,9 @@ def inject(
     # package_spec is anything pip-installable, including package_name, vcs spec,
     #   zip file, or tar.gz file.
     if package_name is None:
-        package_name = _package_name_from_spec(package_spec, venv.python)
+        package_name = _package_name_from_spec(
+            package_spec, venv.python, pip_args=pip_args, verbose=verbose
+        )
 
     venv.install_package(
         package=package_name,

src/pipx/main.py

@@ -21,7 +21,7 @@
 from .util import PipxError, mkdir
 from .venv import VenvContainer
 
-__version__ = "0.15.0.0"
+__version__ = "0.15.0.1"
 
 
 def simple_parse_version(s, segments=4) -> Tuple[Union[int, str], ...]:

tests/test_install.py

@@ -148,3 +148,19 @@ def test_install_python3_5(pipx_temp_env):
         assert not run_pipx_cli(["install", "cowsay", "--python", PYTHON3_5])
     else:
         pytest.skip("python3.5 not on PATH")
+
+
+def test_pip_args_forwarded_to_package_name_determination(
+    pipx_temp_env, caplog, capsys
+):
+    assert run_pipx_cli(
+        [
+            "install",
+            # use a valid spec and invalid pip args
+            "https://github.com/ambv/black/archive/18.9b0.zip",
+            "--verbose",
+            "--pip-args='--asdf'",
+        ]
+    )
+    captured = capsys.readouterr()
+    assert "Cannot determine package name from spec" in captured.err