Skip to content

Commit e89c52f

Browse files
ichard26pradyunsg
andauthored
Correct editable metadata hook return type to str (#209)
`prepare_metadata_for_build_wheel` was initially typed to return Optional[str] just like the editable metadata hook, but it got changed to `str` during review. However, the editable hook's return type was never corrected. This seems to be an oversight as I can't find anything in the PEP 517 or 660 specifications allowing these hooks to return None. Co-authored-by: Pradyun Gedam <[email protected]>
1 parent dc02fcb commit e89c52f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/pyproject_hooks/_impl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def prepare_metadata_for_build_editable(
290290
metadata_directory: str,
291291
config_settings: Optional[Mapping[str, Any]] = None,
292292
_allow_fallback: bool = True,
293-
) -> Optional[str]:
293+
) -> str:
294294
"""Prepare a ``*.dist-info`` folder with metadata for this project.
295295
296296
:param metadata_directory: The directory to write the metadata to

0 commit comments

Comments
 (0)