Skip to content

Commit 00f7524

Browse files
committed
Don't emit warning for explicitly included data files
1 parent 263c321 commit 00f7524

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Diff for: newsfragments/4789.misc.rst

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Don't emit ``Package would be ignored`` warning for explicitly included data files.

Diff for: setuptools/command/build_py.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,10 @@ def analyze_manifest(self) -> None:
194194
files = ei_cmd.filelist.files
195195

196196
check = _IncludePackageDataAbuse()
197+
data_files = {
198+
package: filenames
199+
for package, _, _, filenames in self.get_data_files_without_manifest()
200+
}
197201
for path in self._filter_build_files(files, egg_info_dir):
198202
d, f = os.path.split(assert_relative(path))
199203
prev = None
@@ -208,7 +212,7 @@ def analyze_manifest(self) -> None:
208212
continue # it's a module, not data
209213
else:
210214
importable = check.importable_subpackage(src_dirs[d], f)
211-
if importable:
215+
if importable and f not in data_files[d]:
212216
check.warn(importable)
213217
self.manifest_files.setdefault(src_dirs[d], []).append(path)
214218

0 commit comments

Comments
 (0)