Enforce ruff/flake8-comprehensions rules (C4) #4785
+445
−454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 similar comment
|
|
DimitriPapadopoulos
force-pushed
the
C4
branch
from
bf51fe7 to
1ea7c2c
Compare
|
I think you'll want to enable allow-dict-calls-with-keyword-arguments |
DimitriPapadopoulos
force-pushed
the
C4
branch
3 times, most recently
from
bb995d6 to
5e77363
Compare
|
After adding allow-dict-calls-with-keyword-arguments, most occurrences of C408 have disappeared. A few instances of |
|
I personally think those make sense, it's mainly changing generators of tuples into dict comprehensions. |
FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
FURB142 Use of `set.add()` in a for loop
FURB167 Use of regular expression alias `re.I` FURB167 Use of regular expression alias `re.M` FURB167 Use of regular expression alias `re.S` FURB167 Use of regular expression alias `re.X`
FURB188 Prefer `removesuffix` over conditionally replacing with slice.
FURB192 Prefer `max` over `sorted()` to compute the maximum value in a sequence
C400 Unnecessary generator (rewrite as a `list` comprehension)
C401 Unnecessary generator (rewrite as a `set` comprehension)
C402 Unnecessary generator (rewrite as a `dict` comprehension)
C405 Unnecessary `list` literal (rewrite as a `set` literal)
C408 Unnecessary `dict` call (rewrite as a literal)
C413 Unnecessary `list` call around `sorted()`
C414 Unnecessary `list` call within `sorted()`
C417 Unnecessary `map` usage (rewrite using a generator expression)
C420 Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pull Request Checklist
newsfragments/.(See documentation for details)