Skip tcsh tests on broken tcsh versions (#2817)

Signed-off-by: Bernát Gábor <[email protected]>

Author: gaborbernat

.pre-commit-config.yaml

@@ -24,7 +24,7 @@ repos:
     hooks:
       - id: pyproject-fmt
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.8.3"
+    rev: "v0.8.5"
     hooks:
       - id: ruff-format
       - id: ruff

docs/changelog/2814.bugfix.rst

@@ -0,0 +1 @@
+Skip tcsh tests on broken tcsh versions - by :user:`gaborbernat`.

src/virtualenv/discovery/builtin.py

@@ -5,7 +5,7 @@
 import sys
 from contextlib import suppress
 from pathlib import Path
-from typing import TYPE_CHECKING, Callable
+from typing import TYPE_CHECKING
 
 from virtualenv.info import IS_WIN, fs_path_id
 
@@ -15,7 +15,7 @@
 
 if TYPE_CHECKING:
     from argparse import ArgumentParser
-    from collections.abc import Generator, Iterable, Mapping, Sequence
+    from collections.abc import Callable, Generator, Iterable, Mapping, Sequence
 
     from virtualenv.app_data.base import AppData
 LOGGER = logging.getLogger(__name__)

tests/unit/activation/conftest.py

@@ -77,7 +77,7 @@ def __call__(self, monkeypatch, tmp_path):
         try:
             process = Popen(invoke, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, env=env)
             raw_, _ = process.communicate()
-            raw = raw_.decode()
+            raw = raw_.decode(errors="replace")
             assert process.returncode == 0, raw
         except subprocess.CalledProcessError as exception:
             output = exception.output + exception.stderr

tests/unit/activation/test_csh.py

@@ -1,9 +1,23 @@
 from __future__ import annotations
 
+import sys
+from shutil import which
+from subprocess import check_output
+
+import pytest
+from packaging.version import Version
+
 from virtualenv.activation import CShellActivator
 
 
 def test_csh(activation_tester_class, activation_tester):
+    exe = f"tcsh{'.exe' if sys.platform == 'win32' else ''}"
+    if which(exe):
+        version_text = check_output([exe, "--version"], text=True, encoding="utf-8")
+        version = Version(version_text.split(" ")[1])
+        if version >= Version("6.24.14"):
+            pytest.skip("https://github.com/tcsh-org/tcsh/issues/117")
+
     class Csh(activation_tester_class):
         def __init__(self, session) -> None:
             super().__init__(CShellActivator, session, "csh", "activate.csh", "csh")

tests/unit/seed/wheels/test_acquire.py

@@ -5,7 +5,7 @@
 from datetime import datetime, timezone
 from pathlib import Path
 from subprocess import CalledProcessError
-from typing import TYPE_CHECKING, Callable
+from typing import TYPE_CHECKING
 
 import pytest
 
@@ -16,6 +16,7 @@
 from virtualenv.seed.wheels.util import Wheel, discover_wheels
 
 if TYPE_CHECKING:
+    from collections.abc import Callable
     from unittest.mock import MagicMock
 
     from pytest_mock import MockerFixture