Skip to content

Commit 42a57aa

Browse files
author
Francois
committed
minor test improvements
1 parent 99c386e commit 42a57aa

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

test/kinsky/client_test.clj

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(ns kinsky.client-test
2-
(:require [clojure.test :refer :all :as t]
2+
(:require [clojure.test :refer :all :as t]
33
[clojure.pprint :as pp]
44
[kinsky.client :as client]
55
[kinsky.embedded :as e]))
@@ -32,22 +32,22 @@
3232
(testing "string serializer"
3333
(is (= "foo"
3434
(String.
35-
(.serialize (client/string-serializer) "" "foo")))))
35+
(.serialize (client/string-serializer) "" "foo")))))
3636

3737
(testing "keyword serializer"
3838
(is (= "foo"
3939
(String.
40-
(.serialize (client/keyword-serializer) "" :foo)))))
40+
(.serialize (client/keyword-serializer) "" :foo)))))
4141

4242
(testing "edn serializer"
4343
(is (= "{:a :b, :c :d}"
4444
(String.
45-
(.serialize (client/edn-serializer) "" {:a :b :c :d})))))
45+
(.serialize (client/edn-serializer) "" {:a :b :c :d})))))
4646

4747
(testing "json serializer"
4848
(is (= "[0,1,2]"
4949
(String.
50-
(.serialize (client/json-serializer) "" [0 1 2]))))))
50+
(.serialize (client/json-serializer) "" [0 1 2]))))))
5151

5252
(deftest deserializer
5353
(testing "string deserializer"
@@ -69,12 +69,14 @@
6969
(.getBytes "{\"a\": \"b\", \"c\": \"d\"}"))))))
7070

7171
(deftest config-props
72-
(testing "valid configuration properties"
73-
(is (= {"foo.bar" "0"}
74-
(client/opts->props {:foo.bar 0})))))
72+
(testing "configuration properties"
73+
(is (= {"foo.bar" "0" "foo.baz" "1"}
74+
(client/opts->props {:foo.bar 0
75+
"foo.baz" "1"
76+
:qualified/kw :discarded})))))
7577

7678
(deftest rebalance-listener
77-
(testing "idempotency"
79+
(testing "identity when given a ConsumerRebalanceListener"
7880
(let [sink (client/rebalance-listener (fn [& _]))]
7981
(is (= sink (client/rebalance-listener sink)))))
8082

0 commit comments

Comments
 (0)