Skip to content

Commit d66878a

Browse files
authored
Merge pull request #3125 from Wurschdhaud/switch-shift-click-to-execparams
switch __shiftclick__ to EXEC_PARAMS.config_mode
2 parents fe6c578 + 643e264 commit d66878a

File tree

22 files changed

+45
-88
lines changed
  • extensions
    • pyRevitCore.extension/pyRevit.tab/pyRevit.panel/Settings.smartbutton
    • pyRevitTools.extension/pyRevit.tab
      • Analysis.panel/Tools.stack/Inspect.pulldown
      • Drawing Set.panel
      • Modify.panel
        • edit1.stack/Match.splitpushbutton/Match Properties.pushbutton
        • edit3.stack/Groups.pulldown/Select Topmost Groups.pushbutton
      • Project.panel
      • Selection.panel
        • memo.stack
        • select.stack/Select.pulldown
          • Invert Selection.pushbutton
          • Select All Objects Of Selected Type.pushbutton
          • Select All Vertical Reveals.pushbutton
          • Select Similar Elements In Active View.pushbutton
      • Toggles.panel/toggles1.stack/Tab Coloring.smartbutton

22 files changed

+45
-88
lines changed

extensions/pyRevitCore.extension/pyRevit.tab/pyRevit.panel/Settings.smartbutton/script.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1028,7 +1028,7 @@ def __selfinit__(script_cmp, ui_button_cmp, __rvt__):
10281028
# windows explorer
10291029
# otherwise, will show the Settings user interface
10301030
if __name__ == "__main__":
1031-
if __shiftclick__: # pylint: disable=E0602
1031+
if EXEC_PARAMS.config_mode:
10321032
script.show_file_in_explorer(user_config.config_file)
10331033
elif user_config.is_readonly:
10341034
forms.alert("pyRevit settings are set by your admin.", exitscript=True)

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Inspect.pulldown/Compare Detail Views.deprecate/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from pyrevit import revit, DB, UI
1+
from pyrevit import revit, DB, EXEC_PARAMS
22
from pyrevit import forms
33

44
import diffutils
@@ -16,7 +16,7 @@
1616
comp = diffutils.compare_views(revit.doc,
1717
view_list[0],
1818
view_list[1],
19-
compare_types=__shiftclick__,
19+
compare_types=EXEC_PARAMS.config_mode,
2020
diff_results=res)
2121

2222
forms.alert('Views are smiliar (not identical).'

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Inspect.pulldown/LinesPerViewCounter.pushbutton/LinesPerViewCounter_script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from collections import defaultdict
33

44
from pyrevit import script
5-
from pyrevit import revit, DB
5+
from pyrevit import revit, DB, EXEC_PARAMS
66
from pyrevit.compat import get_elementid_value_func
77

88

@@ -62,7 +62,7 @@ def line_count(document=doc):
6262
if __name__ == '__main__':
6363
output.print_md("\n\n# LINES PER VIEW IN CURRENT DOCUMENT\n___\n\n")
6464
line_count()
65-
if __shiftclick__:
65+
if EXEC_PARAMS.config_mode:
6666
output.print_md("\n\n# LINES PER VIEW IN LINKS\n___\n\n")
6767
revit_links = DB.FilteredElementCollector(doc).OfClass(DB.RevitLinkInstance).ToElements()
6868
for link in revit_links:

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Keynotes.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from collections import defaultdict
1313
from natsort import natsorted
1414

15-
from pyrevit import HOST_APP
15+
from pyrevit import HOST_APP, EXEC_PARAMS
1616
from pyrevit import framework
1717
from pyrevit.framework import System
1818
from pyrevit import coreutils
@@ -1350,7 +1350,7 @@ def window_closing(self, sender, args):
13501350
try:
13511351
KeynoteManagerWindow(
13521352
xaml_file_name='KeynoteManagerWindow.xaml',
1353-
reset_config=__shiftclick__ #pylint: disable=undefined-variable
1353+
reset_config=EXEC_PARAMS.config_mode
13541354
).show(modal=True)
13551355
except Exception as kmex:
13561356
forms.alert(str(kmex), expanded="Creating keynote manager window")

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Print Sheets.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import locale
3030
from collections import namedtuple
3131

32-
from pyrevit import HOST_APP
32+
from pyrevit import HOST_APP, EXEC_PARAMS
3333
from pyrevit import framework
3434
from pyrevit.framework import Windows, Drawing, ObjectModel, Forms, List
3535
from pyrevit import coreutils
@@ -1690,7 +1690,7 @@ def cleanup_sheetnumbers(doc):
16901690
revit.selection.get_selection().clear()
16911691

16921692
# TODO: add copy filenames to sheet list
1693-
if __shiftclick__: # pylint: disable=E0602
1693+
if EXEC_PARAMS.config_mode:
16941694
open_docs = forms.select_open_docs(check_more_than_one=False)
16951695
if open_docs:
16961696
for open_doc in open_docs:

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/List TitleBlocks on Sheets.pushbutton/script.py

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -6,47 +6,7 @@
66
77
"""
88
# pylint: disable=import-error,invalid-name,broad-except,superfluous-parens
9-
from pyrevit import revit
10-
from pyrevit import forms
11-
from pyrevit import script
12-
13-
output = script.get_output()
14-
logger = script.get_logger()
15-
16-
17-
def get_source_sheets():
18-
sheet_elements = forms.select_sheets(
19-
button_name="List TitleBlocks",
20-
use_selection=True,
21-
include_placeholder=False,
22-
)
23-
if not sheet_elements:
24-
script.exit()
25-
return sheet_elements
26-
27-
28-
def print_titleblocks(sheets):
29-
all_tblocks = []
30-
for sheet in sheets:
31-
tblocks = revit.query.get_sheet_tblocks(sheet)
32-
all_tblocks.extend([x.Id for x in tblocks])
33-
for tblock in tblocks:
34-
print(
35-
"SHEET: {0} - {1}\t\tTITLEBLOCK: {2} {3}".format(
36-
sheet.SheetNumber,
37-
sheet.Name,
38-
tblock.Name,
39-
output.linkify(tblock.Id),
40-
)
41-
)
42-
print(
43-
"{}".format(output.linkify(all_tblocks, title="Select All TitleBlocks"))
44-
)
45-
46-
47-
"""Select title blocks on selected sheets for batch editing."""
48-
# pylint: disable=import-error,invalid-name,broad-except,superfluous-parens
49-
from pyrevit import revit
9+
from pyrevit import revit, EXEC_PARAMS
5010
from pyrevit import forms
5111
from pyrevit import script
5212

@@ -85,7 +45,7 @@ def print_titleblocks(sheets):
8545

8646

8747
# orchestrate
88-
if __shiftclick__:
48+
if EXEC_PARAMS.config_mode:
8949
selection = revit.get_selection()
9050
sheets = get_source_sheets()
9151
all_tblocks = []
@@ -94,4 +54,4 @@ def print_titleblocks(sheets):
9454
all_tblocks.extend([x.Id for x in tblocks])
9555
selection.set_to(all_tblocks)
9656
else:
97-
print_titleblocks(get_source_sheets())
57+
print_titleblocks(get_source_sheets())

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Pin All Viewports.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Pin all viewports on active sheet.
55
"""
66

7-
from pyrevit import revit, DB
7+
from pyrevit import revit, DB, EXEC_PARAMS
88
from pyrevit import script
99
from pyrevit import forms
1010

@@ -29,7 +29,7 @@ def pin_viewports(sheet_list):
2929
alreadypinnedcount))
3030

3131

32-
if __shiftclick__:
32+
if EXEC_PARAMS.config_mode:
3333
if isinstance(revit.active_view, DB.ViewSheet):
3434
sel_sheets = [revit.active_view]
3535
else:

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from pathlib import Path
77

8-
from pyrevit import forms
8+
from pyrevit import forms, EXEC_PARAMS
99

1010

1111
def renamepdf(old_name):
@@ -19,7 +19,7 @@ def renamepdf(old_name):
1919

2020
# if user shift-clicks, default to user desktop,
2121
# otherwise ask for a folder containing the PDF files
22-
if __shiftclick__:
22+
if EXEC_PARAMS.config_mode:
2323
basefolder = op.expandvars(r"%userprofile%\desktop")
2424
else:
2525
basefolder = forms.pick_folder()

extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.panel/views.stack/Schedules.pulldown/Export Schedules To CSV.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from pyrevit import forms
1111
from pyrevit import coreutils
12-
from pyrevit import revit, DB
12+
from pyrevit import revit, DB, EXEC_PARAMS
1313
from pyrevit import script
1414

1515
from pyrevit.userconfig import user_config
@@ -24,7 +24,7 @@
2424
basefolder = ''
2525
# if user shift-clicks, default to user desktop,
2626
# otherwise ask for a folder containing the PDF files
27-
if __shiftclick__: #pylint: disable=E0602
27+
if EXEC_PARAMS.config_mode:
2828
destopt, switches = forms.CommandSwitchWindow.show(
2929
["My Desktop", "Where Revit Model Is", "My Downloads", "User Select"],
3030
switches=["Open CSV File","Include Headers"],

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit1.stack/Match.splitpushbutton/Match Properties.pushbutton/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#pylint: disable=import-error,invalid-name,broad-except
88
import pickle
99

10-
from pyrevit import revit, DB
10+
from pyrevit import revit, DB, EXEC_PARAMS
1111
from pyrevit import forms
1212
from pyrevit import script
1313
from pyrevit.compat import get_elementid_value_func
@@ -133,7 +133,7 @@ def remember(src_props):
133133

134134
# main
135135
source_props = []
136-
if __shiftclick__: #pylint: disable=undefined-variable
136+
if EXEC_PARAMS.config_mode:
137137
target_type, source_props = recall()
138138
logger.debug("Recalled data: %s", source_props)
139139

0 commit comments

Comments
 (0)