Skip to content

Fix CLI clone failure by replacing bin with build in deployments#3455

Merged
jmcouffin merged 2 commits into
pyrevitlabs:developfrom
TPJW:fix-pyrevitfile-deployments
Jun 25, 2026
Merged

Fix CLI clone failure by replacing bin with build in deployments#3455
jmcouffin merged 2 commits into
pyrevitlabs:developfrom
TPJW:fix-pyrevitfile-deployments

Conversation

@TPJW

@TPJW TPJW commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a bug where the pyRevit CLI fails to clone because it looks for the old bin directory. This updates pyRevitfile deployments to point to the new build directory.

Fixes #3454

@pyrevitlabs pyrevitlabs deleted a comment from devloai Bot Jun 25, 2026
@jmcouffin

Copy link
Copy Markdown
Contributor

@TPJW have you tested it locally?

@jmcouffin
jmcouffin requested a review from Copilot June 25, 2026 19:18
@jmcouffin jmcouffin added Command Line Utility (CLI) Issues related to pyRevit CLI tool [subsystem] CI/CD Issues and PR related to the CI/CD workflow in github labels Jun 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the root pyRevitfile deployment definitions so that image-based deployments used by the pyRevit CLI reference the current repository directory layout, avoiding clone failures caused by a missing legacy bin folder.

Changes:

  • Updated all [deployments] entries in pyRevitfile to use build instead of bin (core/corex/base/basepublic/basex).
  • Ensures pyrevit clone ... <deployment> can deploy from the GitHub branch archive without failing during directory copy.

Removed 'build' from core, base, basepublic, and basex deployments.

@jmcouffin jmcouffin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will request re a release in order to work

@jmcouffin

Copy link
Copy Markdown
Contributor

Adjusted with the correct fix. Will try to make a release on the go since this requires a merge to master

@jmcouffin
jmcouffin merged commit a9e4197 into pyrevitlabs:develop Jun 25, 2026
@TPJW

TPJW commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

This will request re a release in order to work

Was just going to bring up how i couldn't do a full test from a .zip image, thanks!
I'll see how this release looks, but there may be some cascading issues with the refactor from bin to build when loading the engine and a function called WarnIfBinEnginesMissing(); i could be wrong though

@jmcouffin

Copy link
Copy Markdown
Contributor

WarnIfBinEnginesMissing()

Noted, and yes, but this is minor for now.

jmcouffin added a commit that referenced this pull request Jun 25, 2026
* Next Version [skip ci]

* Fix CLI clone failure by replacing bin with build in deployments (#3455)

* Fix CLI clone failure by replacing bin with build in deployments

* Remove 'build' from deployment configurations

Removed 'build' from core, base, basepublic, and basex deployments.

---------

Co-authored-by: Jean-Marc Couffin <jmcouffin@users.noreply.github.com>

* release: v6.5.3

Co-authored-by: Jean-Marc Couffin <jmcouffin@users.noreply.github.com>

---------

Co-authored-by: TPJW <148268400+TPJW@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Issues and PR related to the CI/CD workflow in github Command Line Utility (CLI) Issues related to pyRevit CLI tool [subsystem]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pyrevit clone fails due to 'bin' directory missing in deployments configuration

3 participants