-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
breaking changebugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Milestone
Description
The current structure of the cosmic_gps instrument needs to be updated for the pysat 3.0.0 release. While working on bugs related to pysat/pysat#337, a number of areas to improve have been noted, including
- Multiple spacecraft and antennas lead to possible "duplicate" timestamps. The enforcement of unique times on data requires the addition of fractional seconds to the data timestamps. While this does not affect some analysis methods (eg, climatology), a better long-term solution for this is to move to xarray.
- This also affects the file lists. The current system solves this by adding fractional seconds (<0.01s in total) to timestamps both for the file lists. Because "duplicate" files are effectively allowed, a user could potentially download multiple versions of a data file over the lifetime of the mission and wind up loading all data sets, including old versions of the same file.
- The download method and storing using the 'YYYY.DDD' format makes the parsing less clean. There's currently a workaround in BUG: recognize string variables in parse_delimited_files pysat#439, but this could be cleaned up with a breaking change.
Proposed updates:
- Handle the data using xarray
- Expand the fname string to include version numbers and potentially other keywords. May require updates in the core instrument object (breaking)
- Improve the directory structure by letting pysat handle the day subdirectories (breaking)
ref: https://cdaac-www.cosmic.ucar.edu/cdaac/cgi_bin/fileFormats.cgi?type=ionPrf
Metadata
Metadata
Assignees
Labels
breaking changebugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request