Skip to content

Commit cc4bc1e

Browse files
committed
correct mess in log_redis_info
1 parent fd369c2 commit cc4bc1e

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
History
44
-------
55

6+
v0.10.1 (2017-08-16)
7+
....................
8+
* correct format of ``log_redis_info``
9+
610
v0.10.0 (2017-08-16)
711
....................
812
* log redis version when starting worker, fix #64

arq/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,10 @@ async def log_redis_info(self, log_func):
108108
pool = await self.get_redis_pool()
109109
async with pool.get() as redis:
110110
info = await redis.info()
111-
# from pprint import pprint
112-
# pprint(info)
113111
log_func(
114112
f'redis version: {info["server"]["redis_version"]}, '
115113
f'mem. usage: {info["memory"]["used_memory_human"]}, '
116-
f'clients connected: {info["clients"]["connected_clients"]}, '
114+
f'clients connected: {info["clients"]["connected_clients"]}'
117115
)
118116

119117
async def close(self):

arq/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
__all__ = ['VERSION']
44

5-
VERSION = StrictVersion('0.10.0')
5+
VERSION = StrictVersion('0.10.1')

tests/test_utils.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,21 @@ async def test_redis_success_log(loop, caplog):
7575
await pool.wait_closed()
7676

7777

78+
async def test_redis_log(loop, caplog):
79+
r = RedisMixin(loop=loop)
80+
81+
log_msgs = []
82+
83+
def _log(s):
84+
log_msgs.append(s)
85+
86+
await r.log_redis_info(_log)
87+
await r.close()
88+
print(log_msgs)
89+
assert len(log_msgs) == 1
90+
assert 'redis version: 3.' in log_msgs[0]
91+
92+
7893
@pytest.mark.parametrize('previous,expected,kwargs', [
7994
(
8095
datetime(2016, 6, 1, 12, 10, 10),

0 commit comments

Comments
 (0)